-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROF-9250: Enable timeline and CPU profiling by default #4149
Conversation
Overall package sizeSelf size: 6.26 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4149 +/- ##
==========================================
+ Coverage 85.23% 85.31% +0.07%
==========================================
Files 247 247
Lines 10961 10940 -21
Branches 33 33
==========================================
- Hits 9343 9333 -10
+ Misses 1618 1607 -11 ☔ View full report in Codecov by Sentry. |
Some profiler tests are still failing on Windows, probably because timeline is not available here. |
ac5e0ea
to
80c63c5
Compare
80c63c5
to
5e1275c
Compare
Rebased to fix merge conflicts; 4 of the previous 10 commits were now empty 'cause they were incorporated into master earlier; we're left with 6. |
BenchmarksBenchmark execution time: 2024-04-08 12:35:44 Comparing candidate commit 5e1275c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics. |
* Add non-experimental DD_PROFILING_CPU_ENABLED * Turn timelines and CPU profile on by default on non-Windows platforms
* Add non-experimental DD_PROFILING_CPU_ENABLED * Turn timelines and CPU profile on by default on non-Windows platforms
* Add non-experimental DD_PROFILING_CPU_ENABLED * Turn timelines and CPU profile on by default on non-Windows platforms
* Add non-experimental DD_PROFILING_CPU_ENABLED * Turn timelines and CPU profile on by default on non-Windows platforms
* Add non-experimental DD_PROFILING_CPU_ENABLED * Turn timelines and CPU profile on by default on non-Windows platforms
* Add non-experimental DD_PROFILING_CPU_ENABLED * Turn timelines and CPU profile on by default on non-Windows platforms
What does this PR do?
Motivation
Timeline and CPU profiling have now been extensively tested, and it is considered safe to have them on by default. While adjusting tests for the on-by-default behavior, I also noticed some edge cases in the behavior that I fixed, namely: