Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.11.0 #4254

Merged
merged 26 commits into from
Apr 23, 2024
Merged

v5.11.0 #4254

merged 26 commits into from
Apr 23, 2024

Conversation

dmellonielet and others added 23 commits April 22, 2024 11:52
* Add non-experimental DD_PROFILING_CPU_ENABLED

* Turn timelines and CPU profile on by default on non-Windows platforms
* Sum waf.duration* metrics

* Test multiple calls

* Round 2. Do not rely on span tag and use metrics stored by telemetry

* waf.duration and waf.durationExt do not depend on whether telemetry is enabled or not

* Include a test with telemetry enabled and metrics disabled
* Avoid run sequelize plugin test with non compatible mysql2

* Avoid run sequelize plugin test with non compatible mysql2

* Fix typo

* Fix typo

* Add comment with the test combination constraint explanation

* Update packages/dd-trace/test/appsec/iast/analyzers/sql-injection-analyzer.sequelize.plugin.spec.js

Co-authored-by: simon-id <simon.id@datadoghq.com>

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
* Emit an event when profiles are submitted
* Emit span start event
* Emit an app-closing event so telemetry users can publish final metrics
* SSI Telemetry class
* Telemetry mock profiler
Because commas are normalized to underscores in backend anyway.
* Update secret rules

* Update generic rule

* Update test suite

* simplify analyzer

* Split hardcoded secrets and passwords

* Include a rule mode to differenciate between ValueOnly rules and NameAndValue rules

* Use HardcodedBaseAnalyzer constructor to pass the rule lists

* Change hardcoded password rule id

* Rename rule 'mode' as 'type'

* Modify test, extract password rule to its own file and clean up

* Use hardcoded-rule-type constants

* Remove eslint comment

* declare and after export class

* Use constants

* test typo

Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>

---------

Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
* implement OTEL env var support for node.js
Copy link

github-actions bot commented Apr 22, 2024

Overall package size

Self size: 6.39 MB
Deduped: 60.88 MB
No deduping: 61.16 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2024

Benchmarks

Benchmark execution time: 2024-04-22 13:03:32

Comparing candidate commit 6b4df61 in PR branch v5.11.0-proposal with baseline commit 151fc8e in branch v5.x.

Found 2 performance improvements and 9 performance regressions! Performance is the same for 249 metrics, 6 unstable metrics.

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

  • 🟥 cpu_user_time [+98.205ms; +123.291ms] or [+9.061%; +11.376%]
  • 🟥 instructions [+443.7M instructions; +455.1M instructions] or [+23.079%; +23.670%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟥 cpu_user_time [+79.790ms; +101.028ms] or [+7.583%; +9.602%]
  • 🟥 instructions [+432.9M instructions; +453.0M instructions] or [+24.489%; +25.626%]

scenario:appsec-iast-startup-time-iast-enabled-18

  • 🟥 cpu_user_time [+87.506ms; +124.399ms] or [+6.206%; +8.823%]
  • 🟥 execution_time [+86.504ms; +109.654ms] or [+5.529%; +7.008%]
  • 🟥 instructions [+455.7M instructions; +466.2M instructions] or [+19.774%; +20.229%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18

  • 🟥 instructions [+445.6M instructions; +471.5M instructions] or [+13.685%; +14.482%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18

  • 🟥 instructions [+448.1M instructions; +493.3M instructions] or [+15.607%; +17.182%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-125.486MB; -112.950MB] or [-13.229%; -11.908%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-118.234MB; -101.130MB] or [-12.556%; -10.740%]

@juan-fernandez juan-fernandez marked this pull request as ready for review April 22, 2024 13:00
@juan-fernandez juan-fernandez requested a review from a team as a code owner April 22, 2024 13:00
@juan-fernandez juan-fernandez merged commit aac3c8a into v5.x Apr 23, 2024
107 of 109 checks passed
@juan-fernandez juan-fernandez deleted the v5.11.0-proposal branch April 23, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet