Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report truncation metrics #5380

Merged
merged 8 commits into from
Mar 19, 2025
Merged

report truncation metrics #5380

merged 8 commits into from
Mar 19, 2025

Conversation

IlyasShabi
Copy link
Contributor

@IlyasShabi IlyasShabi commented Mar 7, 2025

What does this PR do?

Report telemetry truncation metrics APPSEC-56393

  • Report waf.input_truncated count metric
  • Report waf.truncated_value_size distribution metric

Plugin Checklist

Additional Notes

Sorry, something went wrong.

Copy link

github-actions bot commented Mar 7, 2025

Overall package size

Self size: 8.99 MB
Deduped: 101.52 MB
No deduping: 102.03 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (700aee6) to head (19ac252).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5380      +/-   ##
==========================================
+ Coverage   79.52%   82.44%   +2.91%     
==========================================
  Files         510      362     -148     
  Lines       22870    16905    -5965     
==========================================
- Hits        18188    13937    -4251     
+ Misses       4682     2968    -1714     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IlyasShabi IlyasShabi force-pushed the ishabi/truncation-telemetry branch from 1c948a0 to 002eca3 Compare March 7, 2025 15:41
@pr-commenter
Copy link

pr-commenter bot commented Mar 7, 2025

Benchmarks

Benchmark execution time: 2025-03-19 08:41:44

Comparing candidate commit 19ac252 in PR branch ishabi/truncation-telemetry with baseline commit 700aee6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 7, 2025

Datadog Report

Branch report: ishabi/truncation-telemetry
Commit report: 485f7c7
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 806 Passed, 0 Skipped, 11m 51.07s Total Time

@IlyasShabi IlyasShabi marked this pull request as ready for review March 7, 2025 15:57
@IlyasShabi IlyasShabi requested a review from a team as a code owner March 7, 2025 15:57
@IlyasShabi IlyasShabi marked this pull request as draft March 18, 2025 09:06
@IlyasShabi IlyasShabi marked this pull request as ready for review March 18, 2025 12:32
simon-id
simon-id previously approved these changes Mar 18, 2025
@IlyasShabi IlyasShabi marked this pull request as draft March 18, 2025 14:40
@IlyasShabi IlyasShabi marked this pull request as ready for review March 18, 2025 15:18
@IlyasShabi IlyasShabi merged commit 010910f into master Mar 19, 2025
422 checks passed
@IlyasShabi IlyasShabi deleted the ishabi/truncation-telemetry branch March 19, 2025 08:55
juan-fernandez pushed a commit that referenced this pull request Mar 19, 2025
* report truncation metrics

* truncation flags names suggestions

* add input truncated to waf requests

* add more test for input_truncated
@juan-fernandez juan-fernandez mentioned this pull request Mar 19, 2025
juan-fernandez pushed a commit that referenced this pull request Mar 19, 2025
* report truncation metrics

* truncation flags names suggestions

* add input truncated to waf requests

* add more test for input_truncated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants