Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.43.0 proposal #5437

Merged
merged 8 commits into from
Mar 19, 2025
Merged

v5.43.0 proposal #5437

merged 8 commits into from
Mar 19, 2025

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Mar 19, 2025

  • [3b0fe086de] - (SEMVER-MINOR) Update profiler to 5.6.0, for improved idle time sampling. (Attila Szegedi) #5425
  • [010910f1f2] - (SEMVER-MINOR) report truncation metrics (Ilyas Shabi) #5380
  • [700aee67ce] - (SEMVER-PATCH) pin @opentelemetry/instrumentation-express testing to 0.47.1 (Juan Antonio Fernández de Alba) #5433
  • [0d3e671ae0] - (SEMVER-MINOR) add span events as a top level field for v0.4 encoding (William Conti) #5229
  • [e85cdaa8a4] - (SEMVER-PATCH) fix runtime metrics histogram sending invalid data (Roch Devost) #5414
  • [28eaa41569] - (SEMVER-PATCH) fix(llmobs): additional options like for manual span instrumentation are properly recognized (Sam Brenner) #5424
  • [47626620e5] - (SEMVER-PATCH) [test optimization] Fix latest vitest release (Juan Antonio Fernández de Alba) #5427

juan-fernandez and others added 5 commits March 19, 2025 09:45
…are properly recognized (#5424)

* fix approach to passing additional llm observability span options to the tagger
* adds span events at top level for v0.4 encoding

* only serializes span events as top level if DD_TRACE_NATIVE_SPAN_EVENTS=true

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
@juan-fernandez juan-fernandez mentioned this pull request Mar 19, 2025
@juan-fernandez juan-fernandez marked this pull request as ready for review March 19, 2025 08:47
@juan-fernandez juan-fernandez requested a review from a team as a code owner March 19, 2025 08:47
Copy link

github-actions bot commented Mar 19, 2025

Overall package size

Self size: 8.98 MB
Deduped: 101.51 MB
No deduping: 102.03 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 97.72727% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@a06d184). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/dd-trace/src/llmobs/sdk.js 33.33% 2 Missing ⚠️
...es/dd-trace/src/runtime_metrics/runtime_metrics.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5437   +/-   ##
=======================================
  Coverage        ?   79.54%           
=======================================
  Files           ?      511           
  Lines           ?    22901           
  Branches        ?        0           
=======================================
  Hits            ?    18216           
  Misses          ?     4685           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 19, 2025

Datadog Report

Branch report: v5.43.0-proposal
Commit report: 808f324
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 804 Passed, 0 Skipped, 15m 41.29s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2025

Benchmarks

Benchmark execution time: 2025-03-19 11:23:42

Comparing candidate commit 26eb48a in PR branch v5.43.0-proposal with baseline commit a06d184 in branch v5.x.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 913 metrics, 18 unstable metrics.

scenario:startup-with-tracer-22

  • 🟥 cpu_user_time [+16.572ms; +22.508ms] or [+9.987%; +13.565%]
  • 🟥 execution_time [+18.566ms; +19.904ms] or [+9.052%; +9.704%]

* report truncation metrics

* truncation flags names suggestions

* add input truncated to waf requests

* add more test for input_truncated
IlyasShabi
IlyasShabi previously approved these changes Mar 19, 2025
@juan-fernandez juan-fernandez merged commit 33b1184 into v5.x Mar 19, 2025
420 checks passed
@juan-fernandez juan-fernandez deleted the v5.43.0-proposal branch March 19, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants