280819_1112AM_addingChangeFromCn1 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt. Since the user views the BrowserComponent as *the* webview, the fact that it is actually a container which contains a peer component is an implementation detail. The user would expect that the internal peer component should span the full bounds of the browser component.
…omponent that isn't on the current form could cause itself to paint overtop of the current form by issuing a repaint() call. This shouldn't be possible.
This sample isn't working currently. Its the test case for #2871
AreaSeries method rename
…bottom. Did this by changing the font height calculation to be the font's bottom minus top value, rather than its font height. The bottom minus top value is yields the maximum height of a font, whereas the font height is only the recommended height. Usually these are equal, but some fonts seem to have different values here. The problem exhibited itself most clearly with lower case 'g' and 'y'. Also updated the sample for this issue. This is related to #2798
…ere is one. Added methods to ComponentSelector to add/removeLongPressListener. Added samples for longPointerPress events, and for pointer events with lead components.
… test cases to the AccordionSample to test Checkbox alignment in both RTL and LTR.
…ith the middle of the icon. This is more consistent with the way that Label and Button are rendered.
Add RadarChart
…events to be delivered to the CN1 app, when they should have been consumed by the native popover. This is a resurfacing of #2793, which originally fixed this same issue, but when we had to change the view hierarchy for native peers, the strategy failed. Added VideoPlayerSample as a test case to be able to test touch events on native components. This was pulled from the KitchenSink app. Committed CSS files for AccordionSample that I previously forgot to push.
…ined in a scrollable container. Added client properties for text areas to explicitly specify which editing mode to use for a particular text field. textField.putClientProperty(android.editMode, pan) or testField.putClientProperty(android.editMode, resize) (note, params in these examples should be quoted.. just hard to quote in comment.
…ault is center, but now you can align top or bottom as well.
…n whether it is portrait mode or landscape mode.
… should not have a side gap. It should leave that to the content pane.
…o be aligned closer with the label, rather than on the right/left edge (depending on RTL).
…ent regressions. There are still some code paths that aren't covered, but the unit tests deal with most/all situations where there is only a single child in both LTR and RTL. No tests currently that cover the case where wrapping must occur. There is a duplicate of the FlowLayoutTests unit test in the FlowLayoutRTL Test in samples because it is easier to REPL the test as a sample during development.
…ext style to have no effect. This was caused by 5c31748 which aligned SpanLabel text vertically centered with the icon by default. The problem was that this was achieved using a FlowLayout with vertical center alignment, but FlowLayout doesn't fill the bounds of the TextArea to fit its parent, so alignment within the TextArea would have no meaning anymore. Unfortunately there was no layout that would achieve the effect that I wanted (vertically centered, but filling the child bounds horizontally), so I added support for this in BoxLayout. BoxLayout now includes an align property that will cause children to be laid out with a particular vertical alignment. Y_AXIS supports CENTER and BOTTOM values for this. X_AXIS supports CENTER and RIGHT values for this. This alignment has no effect if the children fill the the container. It is only for aligning the empty space. With this change, I was able to use a BoxLayout.Y with center alignment to wrap the TextArea and achieve the effect that I desired. Added a sample to test the regression which was provided in #2891. Also added unit tests for BoxLayout which can serve as a sample and prevent future regressions.
…and can be appended to an OutputStream. This is very handy for providing large amounts of data for processing, so that the data itself doesn't need to be passed around. This interface should be used in a few places in the API to facilitate working with large data objects, such as for file uploads. E.g. For multi-part file uploads the best way to deal with large objects right now is to store them in a file, and then provide the file path to the connection request, so that the platform's native implementation can chunk or stream it appropriately. This interface provides potentially a cleaner more generic way to pass large amounts of data to a connection request.
…() to AsyncResource.
This has a few use cases
DurankGts
pushed a commit
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.