refactor: key handling #4849
Merged
refactor: key handling #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philmoz
force-pushed
the
key-handling
branch
2 times, most recently
from
9061af5 to
b15c789
Compare
philmoz
force-pushed
the
key-handling
branch
2 times, most recently
from
08c4619 to
b5400a9
Compare
added 6 commits
May 21, 2024 16:30
Change some EVT_KEY_FIRST calls to EVT_KEY_BREAK for consistency.
Add Lua events for 'hats as keys' radios.
|
From what I can tell with a test with Pocket, TPro, TX16S and X9D+, this seems to be working fine, with no readily apparent side effects. Tested against radio menus and Yappu / iNav / ELRS standalone Lua and widgets/telem lua. The Cpn key naming changes are much appreciated. |
1 task
This was referenced May 30, 2024
pfeerick
added a commit
that referenced
this pull request
Jul 2, 2024
Most likely related to one of the key handling PRs such as #4849, as this is only changed in main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4838
Clean up key handling code and remove special case tests and calls to killEvents().
At this stage Lua key event names remain unchanged.