fix(color): long press key handling, curve preview not updating

[philmoz]

PR #4849 introduced some subtle bugs into the way long press key handling worked on color radios.
E.G navigate to System Tools menu and long press ENTER key on a tool button.

Fixing this led down a rabbit warren that is the way input events are being handled on color radios - probably needs a serious overhaul.

For now this PR should make long press work like it did previously.

Also fixes an issue where the curve preview on the input edit page does not update if the curve is edited by long pressing on the curve button.

[pfeerick]

Yes, this fixes the problem I raised in #5031 so naturally I found another 🤭

Basically, scrolling order of elements can go... wonky.

Try this... go to Radio Settings -> Radio Setup. If you scroll (use roller and enter only from now on for interaction) you can scroll up and down through all elements in proper order. however, if for instance you alter the month... i.e. ENTER on the month, change it, press ENTER. Now see what happens when you start scrolling... it will jump to the year instead of day on the next click, then back to month, and then day, hour, etc. And if you scroll back, it will go hour, day, month, year, MONTH?, Mode.

Possibly related to that, is that sometimes the highlight is left on the number field you last edited, as well as following navigation/scroll, but is cleared when you scroll past the item again. This wasn't limited to radio setup... I can do this on other pages such as mixes, etc... i.e. as long as don't use RTN to exit field, or use touch keyboard. On that point, mixing the two doesn't work with a "stuck" field.

Do I get a chocolate? 🤣

[philmoz]

Here you go - 🍫

[philmoz]

I think I've fixed the issue with using the ENTER and RTN keys.

[pfeerick]

I think might have also created a new monster in the process... if you touch each of the date and time fields in turn, the heavy/active? outline remains until you use the rotary encoder to scroll and make it refresh. Also, that rotary / touch input issue seems to still be there... where if you use the rotary encoder to select one field, and touch for another, if you then go back and touch the first field, it expects to be using the rotary encoder for input (still/again).

i.e. ENTER on year, then touch month (touch keyboard appears), then touch on year again, touch keyboard disappears, rotary encoder input active again. Yeah, I know, mixing inputs, but it will be done, guaranteed.

[philmoz]

I think I've fixed it (fingers crossed) - thank for doing better testing than I did 😁

[pfeerick]

Beautiful! You can have a 🍫 too! 😄