Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scaling/position/rotation global offset #137

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Bronya-Rand
Copy link
Contributor

This PR addresses Request #88 for a offset on the Position/Scaling/Rotation feature in Brio.
{A7B1D443-5094-4641-8F83-3B9B1947096B}

What's Changed?

  • Added AdjusterOffset to PosingCapabilities.cs.
  • Changed offset logic in editor to use adjuster variable.

@Minmoose
Copy link
Member

Once more, Thanks for the PR! There are some issues with this, but I don't quite have time to explain in detail, basically, certain step values cause the DragFloats to no longer work, I'm also not sure of the placement on UI. Will do more investigation when I have time.

@Bronya-Rand
Copy link
Contributor Author

Thats fine. At least you have something that works as a baseline. I didnt know about the DragFloat thing but obvs UI is up to ya. Just chose where I place it just for testing.

@Bronya-Rand
Copy link
Contributor Author

Bronya-Rand commented Feb 22, 2025

basically, certain step values cause the DragFloats to no longer work

If this is referring to the Offset being at 0, I thought it be intended since let's say someone doesnt want to adjust their settings for that character on accident. If it something else, then take your time to explain when you can. (Basically a 2nd lock to the lock function :p)

@Minmoose
Copy link
Member

Pending to be added in 0.6.0

@Minmoose Minmoose modified the milestones: 0.6.0, 0.5.1 Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants