Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for using the mouse wheel to manipulate the gizmo #19

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

Yuki-Codes
Copy link
Contributor

adds support for manipulating the gizmo with the mouse wheel while an axis is hovered.
also supports holding Ctrl for small changes and Shift` for large ones.

Copy link
Member

@Minmoose Minmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, although the contol of it is a bit clunky,

I also encountered a bug where if you click and hold one of the gizmo's axes and then move the mouse wheel it soft-locks IMGUI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left Shift and Left Ctrl are already in use.

Maby use Right Shift and Right Ctrl with ImGui.IsKeyPressed() instead?

@Yuki-Codes
Copy link
Contributor Author

good calls, I've updated to use a configurable right shift/ctrl instead, and altered it so the scroll-wheel wont do anything if the mouse button is down.

Copy link
Member

@Minmoose Minmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good deal, Thanks for the changes!

@Minmoose Minmoose merged commit 7a3914b into Etheirys:main Jan 19, 2024
2 checks passed
@Yuki-Codes Yuki-Codes deleted the mouse-wheel-gizmo branch January 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants