Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fpca references #636

Merged
merged 5 commits into from
Mar 14, 2025
Merged

Conversation

aleexarias
Copy link
Contributor

Resolves #634

The reference in _fpca is moved into the class docstring instead of the private function it was on, using footcite/footbibliography

  • I have performed a self-review of my code
  • The code conforms to the style used in this package
  • The code is fully documented and typed (type-checked with Mypy)
  • I have added thorough tests for the new/changed functionality

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested.

@aleexarias aleexarias force-pushed the fpca_references_fixed branch 3 times, most recently from 35bf3bf to 9031ea2 Compare October 25, 2024 18:07
@aleexarias aleexarias force-pushed the fpca_references_fixed branch from f2e5cda to 0ea1472 Compare November 8, 2024 10:44
@aleexarias aleexarias force-pushed the fpca_references_fixed branch from 436c23a to 68cb73e Compare November 15, 2024 10:30
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (2f48baa) to head (ba273dc).
Report is 30 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #636      +/-   ##
===========================================
+ Coverage    86.83%   86.85%   +0.02%     
===========================================
  Files          157      157              
  Lines        13522    13566      +44     
===========================================
+ Hits         11742    11783      +41     
- Misses        1780     1783       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it is way better, but I am still unsure. In particular, I would check with Alberto if the page numbers are really necessary and it is not enough to just use the chapter name between parentheses or something like that. Otherwise it feels a bit too verbose.

Apart from that, check the comments.

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small error (probably a typo). Fix that and it is done 😊

@aleexarias aleexarias force-pushed the fpca_references_fixed branch from ace7859 to af58b4d Compare March 9, 2025 11:38
@vnmabus
Copy link
Member

vnmabus commented Mar 9, 2025

I don't know why you added the last two commits, but please drop them (with interactive rebase) as they are probably unnecessary and they are breaking the tests.

@aleexarias aleexarias force-pushed the fpca_references_fixed branch 4 times, most recently from f4401c3 to a0c0bf0 Compare March 9, 2025 12:03
@vnmabus
Copy link
Member

vnmabus commented Mar 9, 2025

There is a conflict. Maybe you can rebase your changes on top of the develop branch to fix it.

@aleexarias aleexarias force-pushed the fpca_references_fixed branch 2 times, most recently from f3a033b to e7fdfb1 Compare March 14, 2025 08:55
aleexarias and others added 5 commits March 14, 2025 10:04
update fpca references

FPCA reference added to docstring + added FPCA explanation in example

Fix references in FPCA
Co-authored-by: Carlos Ramos Carreño <carlosramosca@hotmail.com>

New commit
Changes suggested by vnmabus

+

Added structure Authors (chapter, section) to old inbook references
@aleexarias aleexarias force-pushed the fpca_references_fixed branch from e7fdfb1 to dec8a9f Compare March 14, 2025 09:04
Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnmabus vnmabus merged commit d61f145 into GAA-UAM:develop Mar 14, 2025
8 of 9 checks passed
@vnmabus
Copy link
Member

vnmabus commented Mar 14, 2025

@all-contributors Please add @aleexarias for documentation.

Copy link
Contributor

@vnmabus

I've put up a pull request to add @aleexarias! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix references in FPCA
2 participants