-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fpca references #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested.
35bf3bf
to
9031ea2
Compare
f2e5cda
to
0ea1472
Compare
436c23a
to
68cb73e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #636 +/- ##
===========================================
+ Coverage 86.83% 86.85% +0.02%
===========================================
Files 157 157
Lines 13522 13566 +44
===========================================
+ Hits 11742 11783 +41
- Misses 1780 1783 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it is way better, but I am still unsure. In particular, I would check with Alberto if the page numbers are really necessary and it is not enough to just use the chapter name between parentheses or something like that. Otherwise it feels a bit too verbose.
Apart from that, check the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small error (probably a typo). Fix that and it is done 😊
ace7859
to
af58b4d
Compare
I don't know why you added the last two commits, but please drop them (with interactive rebase) as they are probably unnecessary and they are breaking the tests. |
f4401c3
to
a0c0bf0
Compare
There is a conflict. Maybe you can rebase your changes on top of the develop branch to fix it. |
f3a033b
to
e7fdfb1
Compare
update fpca references FPCA reference added to docstring + added FPCA explanation in example Fix references in FPCA
Co-authored-by: Carlos Ramos Carreño <carlosramosca@hotmail.com> New commit
Changes suggested by vnmabus + Added structure Authors (chapter, section) to old inbook references
e7fdfb1
to
dec8a9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@all-contributors Please add @aleexarias for documentation. |
I've put up a pull request to add @aleexarias! 🎉 |
Resolves #634
The reference in _fpca is moved into the class docstring instead of the private function it was on, using footcite/footbibliography