-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parent run not more present in i.e. after_node_run #623
Labels
bug
Something isn't working
Comments
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When trying to do a nested mlflow run in after_node_run hook the parent run is not active anymore. It worked like a few days ago and my pipelines were nested in the main run defined by the pipelinename.
Context
Goal to achieve is to use the created main MLflowHook with it's pipelinename by using the CLI and create child runs for different nodes.
Steps to Reproduce
I build a simple spaceflight env to reproduce this behaviour here: bf-malefiz/spaceflights-mlflow
The hook sets a tag for before_pipeline_run() and after_node_run() wihtout starting a new one, using the current active. In addition after_node_run creates a nested run.
Expected Result
set_tags without creating a child run should set both tags into the parent/main run
creating a nested run in after_node_run should use the main hook created from the runner
Actual Result
Main mlflow run gets closed and mlflow.active_run() in after_node_run returns None.
A new run with default mlflow option random_name gets created
Your Environment
kedro
andkedro-mlflow
version used (pip show kedro
andpip show kedro-mlflow
):Name: kedro
Version: 0.19.11
Name: kedro-mlflow
Version: 0.14.0
python -V
):Python 3.13.1
Win11 Pro 24H2
Does the bug also happen with the last version on master?
Yes
The text was updated successfully, but these errors were encountered: