Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mlflow not thread safe by reopening the same run before each node #638

Conversation

Galileo-Galilei
Copy link
Owner

… to ensure all the tracking is done within the same run (#623, #624)

Description

Close #623, #624

Development notes

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

… to ensure all the tracking is done within the same run (#623, #624)
@Galileo-Galilei Galileo-Galilei linked an issue Feb 17, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.43%. Comparing base (023049b) to head (cf1acc9).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
kedro_mlflow/framework/hooks/mlflow_hook.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   99.90%   99.43%   -0.48%     
==========================================
  Files          30       28       -2     
  Lines        1054     1062       +8     
==========================================
+ Hits         1053     1056       +3     
- Misses          1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review February 17, 2025 22:06
@Galileo-Galilei Galileo-Galilei merged commit 3f58f2e into master Feb 17, 2025
5 of 6 checks passed
@Galileo-Galilei Galileo-Galilei deleted the 624-kedro-mlflow-with-kedro-01911-produces-multiple-runs branch February 17, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Kedro-mlflow with kedro 0.19.11 produces multiple runs Parent run not more present in i.e. after_node_run
2 participants