-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton for jib integration #1043
Add skeleton for jib integration #1043
Conversation
So far, so good :-) |
So a couple of dev options?
Any preference? |
Codecov Report
@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
- Coverage 40.85% 40.77% -0.09%
==========================================
Files 70 72 +2
Lines 3084 3100 +16
==========================================
+ Hits 1260 1264 +4
- Misses 1699 1711 +12
Partials 125 125
Continue to review full report at Codecov.
|
I like option 2! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
added the feature branch and changed the PR to point to it. I really hope we don't have to keep the feature branch around long and that keeping in sync with master is going to be too painful :) |
added PR for checking "in-syncness" of the feature branch: #1063 |
Mostly following the style of the bazel builder