Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton for jib integration #1043

Merged
merged 4 commits into from
Sep 28, 2018
Merged

Add skeleton for jib integration #1043

merged 4 commits into from
Sep 28, 2018

Conversation

loosebazooka
Copy link
Member

Mostly following the style of the bazel builder

  • Not sure yet where to drop tests for Jib for (since there is no bazel equivalent):
    • runner.go
    • local.go
    • config.go

@dgageot
Copy link
Contributor

dgageot commented Sep 27, 2018

So far, so good :-)

@loosebazooka
Copy link
Member Author

So a couple of dev options?

  1. Merge into a feature branch: jib-skaffold
  2. Keep building like this with "unimplimented errors" until ready to go?

Any preference?

@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #1043 into master will decrease coverage by 0.08%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
- Coverage   40.85%   40.77%   -0.09%     
==========================================
  Files          70       72       +2     
  Lines        3084     3100      +16     
==========================================
+ Hits         1260     1264       +4     
- Misses       1699     1711      +12     
  Partials      125      125
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 53.76% <0%> (-1.11%) ⬇️
pkg/skaffold/build/local/local.go 56.81% <0%> (-5.69%) ⬇️
pkg/skaffold/build/local/jib.go 0% <0%> (ø)
pkg/skaffold/jib/jib.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ecef93...bb906cf. Read the comment docs.

@dgageot
Copy link
Contributor

dgageot commented Sep 28, 2018

I like option 2!

@loosebazooka
Copy link
Member Author

loosebazooka commented Sep 28, 2018

@r2d4 @dgageot can you create a feature branch in this repo for us? jib_skaffold

@loosebazooka loosebazooka changed the title WIP: Add skeleton for jib integration Add skeleton for jib integration Sep 28, 2018
@balopat balopat changed the base branch from master to jib_skaffold September 28, 2018 17:03
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@balopat
Copy link
Contributor

balopat commented Sep 28, 2018

added the feature branch and changed the PR to point to it. I really hope we don't have to keep the feature branch around long and that keeping in sync with master is going to be too painful :)

@balopat balopat merged commit 3bd47ae into GoogleContainerTools:jib_skaffold Sep 28, 2018
@balopat
Copy link
Contributor

balopat commented Sep 28, 2018

added PR for checking "in-syncness" of the feature branch: #1063

@loosebazooka loosebazooka deleted the addJibBuilderSkeleton branch October 9, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants