Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Jib feature-branch #1063

Merged
merged 100 commits into from
Oct 9, 2018
Merged

Merge Jib feature-branch #1063

merged 100 commits into from
Oct 9, 2018

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Sep 28, 2018

This PR is only to keep an eye on the jib_skaffold feature branch, and when it's ready, to merge it.

@codecov-io
Copy link

codecov-io commented Sep 28, 2018

Codecov Report

Merging #1063 into master will increase coverage by 1.38%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage   42.96%   44.35%   +1.38%     
==========================================
  Files          74       84      +10     
  Lines        3403     3709     +306     
==========================================
+ Hits         1462     1645     +183     
- Misses       1801     1909     +108     
- Partials      140      155      +15
Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 56.81% <0%> (-5.69%) ⬇️
pkg/skaffold/runner/runner.go 50.2% <0%> (-1.28%) ⬇️
pkg/skaffold/util/util.go 49.09% <100%> (+3.99%) ⬆️
pkg/skaffold/jib/jib_gradle.go 100% <100%> (ø)
pkg/skaffold/build/local/jib.go 100% <100%> (ø)
pkg/skaffold/util/wrapper_unix.go 100% <100%> (ø)
pkg/skaffold/build/local/jib_maven.go 35% <35%> (ø)
pkg/skaffold/build/local/jib_gradle.go 42.1% <42.1%> (ø)
pkg/skaffold/jib/jib_maven.go 83.33% <83.33%> (ø)
pkg/skaffold/jib/jib.go 89.65% <89.65%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac64849...6f8ce4d. Read the comment docs.

@dgageot dgageot changed the title [wip] Merge Jib feature-branch Merge Jib feature-branch Oct 2, 2018
dgageot and others added 24 commits October 8, 2018 10:19
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
We can’t use skaffold labels to narrow down the
list of pods.

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Sync files in a sequential manner, it makes
the code simpler and anyway, the typical use case
will be to sync one file with one pod.

Signed-off-by: David Gageot <david@gageot.net>
Fixes #1112

Signed-off-by: David Gageot <david@gageot.net>
Merge master into jib_skaffold feature branch
Merge master into jib_skaffold feature branch.
@balopat balopat mentioned this pull request Oct 8, 2018
@loosebazooka
Copy link
Member

Could we merge this and start working against master?

@dgageot dgageot merged commit f67b291 into master Oct 9, 2018
@dgageot dgageot deleted the jib_skaffold branch December 10, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants