Emit TaskEvent messages for DevLoop, Build, and Deploy phases #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5637 +/- ##
==========================================
+ Coverage 70.54% 70.61% +0.06%
==========================================
Files 410 410
Lines 15640 15668 +28
==========================================
+ Hits 11034 11064 +30
+ Misses 3793 3790 -3
- Partials 813 814 +1
Continue to review full report at Codecov.
|
tejal29
reviewed
Apr 7, 2021
|
/cc @etanshaul |
tejal29
reviewed
Apr 9, 2021
| @@ -190,7 +190,7 @@ func newGRPCServer(preferredPort int, usedPorts *util.PortSet) (func() error, in | |||
| } | |||
|
|
|||
| func newHTTPServer(preferredPort, proxyPort int, usedPorts *util.PortSet) (func() error, error) { | |||
| mux := runtime.NewServeMux(runtime.WithProtoErrorHandler(errorHandler)) | |||
| mux := runtime.NewServeMux(runtime.WithProtoErrorHandler(errorHandler), runtime.WithMarshalerOption(runtime.MIMEWildcard, &runtime.JSONPb{OrigName: true, EmitDefaults: true})) | |||
tejal29
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge After: #5641
Related: #5368 #5422
Description
Makes calls to eventV2 package to send out TaskEvent Protos. Also fixes what I believe to be an issue with the
SkaffoldRunner.devIterationfield not being updated after the first iterationUser facing changes (remove if N/A)
User can access v2 events endpoint and see TaskEvent messages being emitted.
Example:
{"result":{"timestamp":"2021-04-07T17:50:08.970854Z","taskEvent":{"id":"DevLoop-0","task":"DevLoop","iteration":0,"status":"InProgress","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:50:08.981571Z","taskEvent":{"id":"Build-0","task":"Build","iteration":0,"status":"InProgress","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:50:17.115852Z","taskEvent":{"id":"Build-0","task":"Build","iteration":0,"status":"Succeeded","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:50:17.990693Z","taskEvent":{"id":"Deploy-0","task":"Deploy","iteration":0,"status":"InProgress","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:50:22.981573Z","taskEvent":{"id":"Deploy-0","task":"Deploy","iteration":0,"status":"Succeeded","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:50:29.014458Z","taskEvent":{"id":"DevLoop-0","task":"DevLoop","iteration":0,"status":"Succeeded","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:53:33.602731Z","taskEvent":{"id":"DevLoop-1","task":"DevLoop","iteration":1,"status":"InProgress","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:53:33.604211Z","taskEvent":{"id":"Build-1","task":"Build","iteration":1,"status":"InProgress","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:53:48.021111Z","taskEvent":{"id":"Build-1","task":"Build","iteration":1,"status":"Succeeded","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:53:48.797537Z","taskEvent":{"id":"Deploy-1","task":"Deploy","iteration":1,"status":"InProgress","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:53:50.213166Z","taskEvent":{"id":"Deploy-1","task":"Deploy","iteration":1,"status":"Succeeded","actionableErr":null}}} {"result":{"timestamp":"2021-04-07T17:53:54.512376Z","taskEvent":{"id":"DevLoop-1","task":"DevLoop","iteration":1,"status":"Succeeded","actionableErr":null}}}Follow-up Work (remove if N/A)
Emit these messages for other phases of skaffold such as Test and StatusCheck