Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] move phase constants from pkg/skaffold/errors to pkg/skaffold/constants #5641

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

MarlonGamez
Copy link
Contributor

Description
This refactor moves the phase constants from pkg/skaffold/errors to pkg/skaffold/constants. @gsquared94 brought that referencing this values as errors.* was awkward and confusing, so we thought we should move them.

@MarlonGamez MarlonGamez requested a review from a team as a code owner April 7, 2021 19:53
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #5641 (597b657) into master (fd96d77) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5641      +/-   ##
==========================================
- Coverage   70.68%   70.67%   -0.02%     
==========================================
  Files         408      408              
  Lines       15581    15582       +1     
==========================================
- Hits        11014    11013       -1     
- Misses       3757     3758       +1     
- Partials      810      811       +1     
Impacted Files Coverage Δ
pkg/skaffold/errors/errors.go 92.72% <ø> (ø)
pkg/skaffold/server/v2/endpoints.go 43.24% <0.00%> (ø)
pkg/skaffold/runner/dev.go 72.83% <88.88%> (+0.16%) ⬆️
pkg/skaffold/event/event.go 91.10% <90.00%> (ø)
pkg/skaffold/event/v2/event.go 61.17% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 85.40% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd96d77...597b657. Read the comment docs.

@tejal29 tejal29 merged commit f280aa8 into GoogleContainerTools:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants