Ko builder: Implement file watch dependencies #6617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6617 +/- ##
==========================================
- Coverage 70.48% 70.02% -0.46%
==========================================
Files 515 523 +8
Lines 23150 23747 +597
==========================================
+ Hits 16317 16629 +312
- Misses 5776 6035 +259
- Partials 1057 1083 +26
Continue to review full report at Codecov.
|
halvards
force-pushed
the
ko-builder-dependencies
branch
2 times, most recently
from
60c7850 to
f2e243f
Compare
halvards
force-pushed
the
ko-builder-dependencies
branch
from
f2e243f to
99c06f6
Compare
tejal29
reviewed
Sep 30, 2021
| // defaultKoDependencies behavior is to watch all files in the context directory | ||
| func defaultKoDependencies() *latestV1.KoDependencies { | ||
| return &latestV1.KoDependencies{ | ||
| Paths: []string{"."}, |
There was a problem hiding this comment.
We shd stay away from having . as default dependency for following reasons
- A change in
.git/*.lockfile will trigger a dev loop - A change in any hidden files (like .swap files or .ides) will trigger dev loop.
Can we instead add **/*.go as default?
There was a problem hiding this comment.
Thanks @tejal29, good point! I've pushed a new commit that uses **/*.go as the default. We'll need the globstar support in #6605 to make this pattern work well.
As a side note, the buildpacks and custom builders both use . as the default:
For those builders we can't really list patterns, since it could be any number of languages. Should we consider a list of default excludes for those builders?
tejal29
reviewed
Sep 30, 2021
Add support for the `dependencies` section in the ko builder config. Use `**/*.go` instead of `.` as the default file watch pattern for the ko builder. As @tejal29 [points out](GoogleContainerTools#6617 (comment)), this prevents unintended image rebuilds based on changes to files in `.git/`, `.idea/`, and `*.swap` files and similar. For this pattern to be effective, the changes in GoogleContainerTools#6605 are required. **Tracking:** GoogleContainerTools#6041 **Related:** GoogleContainerTools#6605
halvards
force-pushed
the
ko-builder-dependencies
branch
from
99c06f6 to
318f83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
dependenciessection in the ko builder config.Use
**/*.goas the default file watch pattern, this prevents unintended image rebuilds based on changes to files in.git/,.idea/, and*.swapfiles and similar.For this pattern to be effective, the changes in #6605 are required.
Tracking: #6041
Related: #6605