Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct ko package imports and logging function call #6673

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Oct 4, 2021

Related: #6647, #6617, #6663

Description
This PR fixes some ko imports which got a bit messed up because of PRs getting merged in an incorrect order. It also changes a call of ...Error() to ...Errorf()

@MarlonGamez MarlonGamez requested a review from a team as a code owner October 4, 2021 22:09
@MarlonGamez MarlonGamez requested a review from gsquared94 October 4, 2021 22:09
@google-cla google-cla bot added the cla: yes label Oct 4, 2021
@MarlonGamez MarlonGamez changed the title fix: correct ko package imports fix: correct ko package imports and logging function call Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #6673 (f511b0b) into main (290280e) will decrease coverage by 0.70%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6673      +/-   ##
==========================================
- Coverage   70.48%   69.78%   -0.71%     
==========================================
  Files         515      523       +8     
  Lines       23150    23833     +683     
==========================================
+ Hits        16317    16631     +314     
- Misses       5776     6116     +340     
- Partials     1057     1086      +29     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
pkg/diag/validator/resource.go 47.05% <66.66%> (ø)
pkg/skaffold/build/docker/docker.go 86.44% <66.66%> (-2.85%) ⬇️
pkg/skaffold/build/docker/errors.go 63.33% <80.00%> (-2.23%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45329d4...f511b0b. Read the comment docs.

@MarlonGamez MarlonGamez merged commit f15f502 into GoogleContainerTools:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants