Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tokens of lengths 5-7 #329

Merged
merged 7 commits into from
Mar 24, 2025

Conversation

zalenskivolt
Copy link
Contributor

@zalenskivolt zalenskivolt commented Mar 20, 2025

Closes #299

@zalenskivolt zalenskivolt requested review from twyatt and a team as code owners March 20, 2025 01:07
@zalenskivolt zalenskivolt requested a review from davertay-j March 20, 2025 01:07
@twyatt twyatt added the patch Changes that should bump the PATCH version number label Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.91%. Comparing base (7cea026) to head (4dd2bd0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   58.52%   58.91%   +0.38%     
==========================================
  Files           8        8              
  Lines         639      645       +6     
  Branches      145      146       +1     
==========================================
+ Hits          374      380       +6     
  Misses        228      228              
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I pushed some commits that restructure the unit tests.
Will merge after getting another approval.

@twyatt twyatt changed the title Support tokens of any length Add support for tokens of lengths 5-7 Mar 21, 2025
Copy link
Contributor

@davertay-j davertay-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thanks @zalenskivolt

@twyatt twyatt enabled auto-merge (squash) March 24, 2025 16:55
@twyatt twyatt merged commit b3f0d52 into JuulLabs:main Mar 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Changes that should bump the PATCH version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't decode Token of length 6
3 participants