Fix MPAS-A dycore-only build in version 8.2.0 #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building MPAS-A as a dycore, all physics-related components are disabled. An example scenario of this is for use with CAM/CAM-SIMA. However, the MPAS-A registry file in version 8.2.0 contains the following regressions, which cause the dycore-only build to break: * The MPAS-A registry file introduced a new stream, `da_state`, which unconditionally includes variables that exist only when physics are enabled. * The MPAS-A registry file unconditionally includes a new registry file from Noah-MP, which is applicable only when physics are enabled. Fix MPAS-A dycore-only build by guarding the above regions with the `DO_PHYSICS` macro.
mgduda
requested changes
Aug 6, 2024
src/core_atmosphere/Makefile
Outdated
|
|
||
| # If MPAS_CAM_DYCORE is found in CPPFLAGS, PHYSICS will become undefined automatically | ||
| # | ||
| ifeq ($(findstring MPAS_CAM_DYCORE,$(CPPFLAGS)),) |
There was a problem hiding this comment.
Although I agree that this is a reasonable change in principle, I think it may be outside the scope what we want to include in the v8.2.1 release. My understanding is that CAM's build already ensured that DO_PHYSICS was not defined, and the need for this change may be due to the reuse of makefiles in ongoing work on CAM-SIMA?
There was a problem hiding this comment.
Yes, CAM maintains its own Makefiles so this change is not needed. This change is for CAM-SIMA because it tries to be as close to the upstream MPAS-A as possible.
I have dropped the commit b3fc19a. The PR descriptions were also updated to no longer mention physics being disabled for dycore-only build.
There was a problem hiding this comment.
I fully support creating a separate PR to the develop branch with this MPAS_CAM_DYCORE logic.
kuanchihwang
force-pushed
the
stg/fix-dycore-only-build
branch
from
b3fc19a to
520d165
Compare
gdicker1
approved these changes
Aug 6, 2024
mgduda
approved these changes
Aug 6, 2024
mgduda
added a commit
that referenced
this pull request
Aug 7, 2024
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS infrastructure. Specific changes in this merge include: * Improved detection of an 'mpi_f08' module (PR #1202), as well as improved detection of netCDF and PnetCDF library paths (PR #1203), in the top-level Makefile. * The addition of a missing dependency in the physics Makefile to correct parallel build issues (PR #1204). * Fixes to the CMake build files used by MPAS-JEDI (PR #1205). * Fixes to double-precision builds of MPAS-Atmosphere (PR #1207, PR #1208). * Correction of the calculation of height AGL used in the computation of 1-km radar reflectivity fields (PR #1213). * Correction of an issue that prevented the MYNN PBL scheme from being used without also using the Thompson aerosol-aware microphysics (PR #1215). * Fixes to allow MPAS-Atmosphere to be built without physics (i.e., dynamics- only builds) (PR #1221). * Various code cleanup and minor corrections (PR #1206, PR #1212, PR #1224, PR #1226).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building MPAS-A as a dycore, all physics-related components are disabled. An example scenario of this is for use with CAM/CAM-SIMA.
However, the MPAS-A registry file in version 8.2.0 contains the following regressions, which cause the dycore-only build to break:
da_state, which unconditionally includes variables that exist only when physics are enabled.This PR fixes MPAS-A dycore-only build by guarding the above regions with the
DO_PHYSICSmacro.For stand-alone MPAS-A, this PR is an NFC (No Functional Change).