Add core_physics dependencies for mpas_atmphys_lsm_noahmpfinalize module #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgduda
requested changes
Jul 8, 2024
islas
force-pushed
the
mpas_atmphys_lsm_noahmpfinalize-deps
branch
from
526f4b0 to
df7bce8
Compare
|
@islas Can you add some detail to the commit message (and use capitalization where appropriate)? A couple of questions to consider for the commit message:
|
|
Is this roughly what you are looking for from the commit message?
I'm refraining from saying "NoahMP and framework are already compiled by the time the core_physics target is started" since the fix is based on a commit that does not have those fix in it, thus would be referring to future patches that have yet to occur if one were to try and take this individual commit. |
islas
force-pushed
the
mpas_atmphys_lsm_noahmpfinalize-deps
branch
from
df7bce8 to
f940356
Compare
…ize.o Add the object dependencies in the makefile for mpas_atmphys_lsm_noahmpfinalize.o specific to the objects created under core_physics, i.e. any use statement that reference modules compiled as part of the core_physics target. Modules originating from NoahMP and framework are ignored as they should be handled separately before the core_physics target is started.
islas
force-pushed
the
mpas_atmphys_lsm_noahmpfinalize-deps
branch
from
f940356 to
5f25019
Compare
islas
changed the title
mgduda
approved these changes
Aug 6, 2024
This was referenced Aug 6, 2024
mgduda
added a commit
that referenced
this pull request
Aug 7, 2024
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS infrastructure. Specific changes in this merge include: * Improved detection of an 'mpi_f08' module (PR #1202), as well as improved detection of netCDF and PnetCDF library paths (PR #1203), in the top-level Makefile. * The addition of a missing dependency in the physics Makefile to correct parallel build issues (PR #1204). * Fixes to the CMake build files used by MPAS-JEDI (PR #1205). * Fixes to double-precision builds of MPAS-Atmosphere (PR #1207, PR #1208). * Correction of the calculation of height AGL used in the computation of 1-km radar reflectivity fields (PR #1213). * Correction of an issue that prevented the MYNN PBL scheme from being used without also using the Thompson aerosol-aware microphysics (PR #1215). * Fixes to allow MPAS-Atmosphere to be built without physics (i.e., dynamics- only builds) (PR #1221). * Various code cleanup and minor corrections (PR #1206, PR #1212, PR #1224, PR #1226).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
mpas_atmphys_lsm_noahmpfinalizeadded in #1161 does not have the appropriate dependencies in the respective makefile.This adds the necessary dependencies to the
mpas_atmphys_lsm_noahmpfinalize.o