fix: Avoid spammy logging on hitting the entwork's BoundedExecutor (#763

)

We operate an executor with a bound on the concurrent number of messages (see #463, #559, #706).
PR #472 added logging for the bound being hit.

We expect the executors to operate for a long time at this limit (e.g. in recovery situation).
The spammy logging is not usfeful

This removes the logging of the concurrency bound being hit.
Fixes #759

narwhal/network/src/lib.rs

@@ -57,4 +57,4 @@ impl<T> std::future::Future for CancelOnDropHandler<T> {
 //
 // The exact number here probably isn't important, the key things is that it should be finite so
 // that we don't create unbounded numbers of tasks.
-pub const MAX_TASK_CONCURRENCY: usize = 200;
+pub const MAX_TASK_CONCURRENCY: usize = 500;

narwhal/network/src/primary.rs

@@ -12,7 +12,6 @@ use rand::{rngs::SmallRng, SeedableRng as _};
 use std::collections::HashMap;
 use tokio::{runtime::Handle, task::JoinHandle};
 use tonic::transport::Channel;
-use tracing::warn;
 use types::{
     BincodeEncodedPayload, PrimaryMessage, PrimaryToPrimaryClient, PrimaryToWorkerClient,
     PrimaryWorkerMessage,
@@ -63,13 +62,10 @@ impl PrimaryNetwork {
     fn update_metrics(&self) {
         if let Some(m) = &self.metrics {
             for (addr, executor) in &self.executors {
-                let available = executor.available_capacity();
-
-                m.set_network_available_tasks(available as i64, Some(addr.to_string()));
-
-                if available == 0 {
-                    warn!("Executor in network:{} and module:{} available tasks is 0 for client address: {}", m.network_type(), m.module_tag(), addr);
-                }
+                m.set_network_available_tasks(
+                    executor.available_capacity() as i64,
+                    Some(addr.to_string()),
+                );
             }
         }
     }

narwhal/network/src/worker.rs

@@ -11,7 +11,6 @@ use rand::{rngs::SmallRng, SeedableRng as _};
 use std::collections::HashMap;
 use tokio::{runtime::Handle, task::JoinHandle};
 use tonic::transport::Channel;
-use tracing::warn;
 use types::{
     BincodeEncodedPayload, WorkerMessage, WorkerPrimaryMessage, WorkerToPrimaryClient,
     WorkerToWorkerClient,
@@ -61,16 +60,10 @@ impl WorkerNetwork {
     fn update_metrics(&self) {
         if let Some(m) = &self.metrics {
             for (addr, executor) in &self.executors {
-                let available = executor.available_capacity();
-
                 m.set_network_available_tasks(
                     executor.available_capacity() as i64,
                     Some(addr.to_string()),
                 );
-
-                if available == 0 {
-                    warn!("Executor in network:{} and module:{} available tasks is 0 for client address: {}", m.network_type(), m.module_tag(), addr);
-                }
             }
         }
     }