Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the clarity of handle_object_info_request in authority.rs #472

Closed
lxfind opened this issue Feb 17, 2022 · 0 comments · Fixed by #484
Closed

Improve the clarity of handle_object_info_request in authority.rs #472

lxfind opened this issue Feb 17, 2022 · 0 comments · Fixed by #484

Comments

@lxfind
Copy link
Contributor

lxfind commented Feb 17, 2022

handle_object_info_request currently serves two purposes:

  1. Return the historical information (ref, cert) at a specific version about an object
  2. Return the latest object state (in fact, this part is always returned).

It can be confusing to mix the two functionalities. For example, there are may be specific checks we want to do when requesting the latest object (cross checking the object digest and etc.). And we want to make sure we don't use the latest object state in the response if we are requesting the historical information.
Some context on the discussion:
https://mysten-labs.slack.com/archives/C02GD7J9HUM/p1645124209747649
@lxfind lxfind linked a pull request Feb 18, 2022 that will close this issue
Add ObjectInfoRequestKind with two different types: latest and past #484
Merged
mwtian pushed a commit that referenced this issue Sep 12, 2022
@akichidis
[metrics] adding metrics on the network executors (#472)
f4ef6a2
mwtian pushed a commit that referenced this issue Sep 12, 2022
@huitseeker
fix: Avoid spammy logging on hitting the entwork's BoundedExecutor (#763
801f306 
)

We operate an executor with a bound on the concurrent number of messages (see #463, #559, #706).
PR #472 added logging for the bound being hit.

We expect the executors to operate for a long time at this limit (e.g. in recovery situation).
The spammy logging is not usfeful

This removes the logging of the concurrency bound being hit.
Fixes #759
mwtian pushed a commit to mwtian/sui that referenced this issue Sep 29, 2022
@akichidis
[metrics] adding metrics on the network executors (MystenLabs#472)
a0b2e6e
mwtian pushed a commit to mwtian/sui that referenced this issue Sep 29, 2022
@huitseeker
fix: Avoid spammy logging on hitting the entwork's BoundedExecutor (M…
4fcbf7b 
…ystenLabs#763)

We operate an executor with a bound on the concurrent number of messages (see MystenLabs#463, MystenLabs#559, MystenLabs#706).
PR MystenLabs#472 added logging for the bound being hit.

We expect the executors to operate for a long time at this limit (e.g. in recovery situation).
The spammy logging is not usfeful

This removes the logging of the concurrency bound being hit.
Fixes MystenLabs#759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ObjectInfoRequestKind with two different types: latest and past MystenLabs/sui
1 participant
@lxfind