Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serde] re-generate serialization formats #515

Closed
huitseeker opened this issue Feb 22, 2022 · 1 comment · Fixed by #571
Closed

[serde] re-generate serialization formats #515

huitseeker opened this issue Feb 22, 2022 · 1 comment · Fixed by #571
Labels
Type: Bug Something isn't working

Comments

@huitseeker
Copy link
Contributor

huitseeker commented Feb 22, 2022 •
edited
Loading

We've unplugged the serde_reflection tracer at generate_formats.rs, to allow us to define new data structures without maintaining it.

Now that our structures are more stable, we should re-start tracking of a BCS format for Sui data structures, and re-activate the test at :
https://github.com/MystenLabs/fastnft/blob/main/sui_core/tests/format.rs

Prequel at #516
@huitseeker huitseeker added Type: Bug Something isn't working help wanted labels Feb 22, 2022
@huitseeker huitseeker mentioned this issue Feb 22, 2022
Merged
@huitseeker
Copy link
Contributor Author

More detail in this comment #516 (comment)

@huitseeker huitseeker mentioned this issue Feb 25, 2022
Merged
huitseeker added a commit that referenced this issue Feb 25, 2022
@huitseeker
fix: re-activate the BCS serialization reflection tests
eac8255 
This tests we do not derive from the generator output.
Fixes #515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[serialization] Repair BCS serialization generator & tests
1 participant
@huitseeker