[serialization] Repair BCS serialization generator & tests #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
requested review from
velvia,
sblackshear,
gdanezis,
asonnino,
Clay-Mysten,
lxfind,
oxade and
patrickkuo
This equips the tracer for our BCS YAML auto-generated serialized format documentation and re-generates the corresponding YAML file
This tests we do not derive from the generator output. Fixes #515
lxfind
approved these changes
Feb 25, 2022
| tracer.trace_value(&mut samples, &pk)?; | ||
|
|
||
| // We have two signature types: one for Authority Signatures, which don't include the PubKey ... | ||
| let sig: AuthoritySignature = kp.sign(b"hello world"); |
There was a problem hiding this comment.
Are these like example code?
There was a problem hiding this comment.
No, they are not. Think of them as fuzz samples, they're example values used by a reflection system to describe the involved types.
Here's the doc: https://github.com/novifinancial/serde-reflection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-plugs the serde_reflection generator for our serialized message format, and the unit test checking we do not drift from its output unintentionally.
Fixes #515