Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP and Transfer Manifest duplicate files and LIDVIDs #29

Closed
jordanpadams opened this issue Apr 13, 2020 · 0 comments · Fixed by #38
Closed

SIP and Transfer Manifest duplicate files and LIDVIDs #29

jordanpadams opened this issue Apr 13, 2020 · 0 comments · Fixed by #38
Assignees
Labels
bug Something isn't working

Comments

@jordanpadams
Copy link
Member

Describe the bug
Running against the LADEE test bundle it produces duplicates of the applicable files in the SIP and transfer manifest.

Other thoughts
We should include in this bug fix an regression test that can be part of the CI/CD that tests running pds-deep-archive against the ladee test bundle and verifies what is output from the software produces what we have in test/data/ladee_test/valid/.

@jordanpadams jordanpadams added bug Something isn't working triage-needed labels Apr 13, 2020
@jordanpadams jordanpadams added this to the PDS.15 (ends 2020-04-22) milestone Apr 13, 2020
nutjob4life added a commit that referenced this issue Apr 20, 2020
…empting to catalog them while also finding primaries

    -   Also: make the pairing of lidvid → xml file unique to avoid redundnant cache entries
        -   Use `insert or ignore`
    -   Add a functional test that compares generated SIP with "valid" SIP
        -   And add framework for unit+functional+integration tests
-   Test data accessible via setuptools `pkg_resources`
-   Resolve #27: An *attempt* to tag test builds for test PyPI with both a date and timestamp; this requires dropping `--tag-date` and coming up with our own date+time format—and hoping that PyPI doesn't enforce its more capricious requirements on release naming
-   Add running tests in the CI/CD GitHub Action
-   Add ability to run tests with `setup test` as well as buildout's `bin/test`
-   Fix extra newlines in log messages
-   Remove need of extra `.strip()` calls by using a smarter regexp
-   PEP-8 cleanups: remove needless `+` for string concatenation
-   Arg list documentation in function calls
-   Remove exec bit from test data files
jordanpadams pushed a commit that referenced this issue Apr 20, 2020
…empting to catalog them while also finding primaries (#38)

-   Also: make the pairing of lidvid → xml file unique to avoid redundnant cache entries
        -   Use `insert or ignore`
    -   Add a functional test that compares generated SIP with "valid" SIP
        -   And add framework for unit+functional+integration tests
-   Test data accessible via setuptools `pkg_resources`
-   Resolve #27: An *attempt* to tag test builds for test PyPI with both a date and timestamp; this requires dropping `--tag-date` and coming up with our own date+time format—and hoping that PyPI doesn't enforce its more capricious requirements on release naming
-   Add running tests in the CI/CD GitHub Action
-   Add ability to run tests with `setup test` as well as buildout's `bin/test`
-   Fix extra newlines in log messages
-   Remove need of extra `.strip()` calls by using a smarter regexp
-   PEP-8 cleanups: remove needless `+` for string concatenation
-   Arg list documentation in function calls
-   Remove exec bit from test data files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants