Fix duplicate SIP and Transfer Manifest issue #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empting to catalog them while also finding primaries
- Also: make the pairing of lidvid → xml file unique to avoid redundnant cache entries
- Use `insert or ignore`
- Add a functional test that compares generated SIP with "valid" SIP
- And add framework for unit+functional+integration tests
- Test data accessible via setuptools `pkg_resources`
- Resolve #27: An *attempt* to tag test builds for test PyPI with both a date and timestamp; this requires dropping `--tag-date` and coming up with our own date+time format—and hoping that PyPI doesn't enforce its more capricious requirements on release naming
- Add running tests in the CI/CD GitHub Action
- Add ability to run tests with `setup test` as well as buildout's `bin/test`
- Fix extra newlines in log messages
- Remove need of extra `.strip()` calls by using a smarter regexp
- PEP-8 cleanups: remove needless `+` for string concatenation
- Arg list documentation in function calls
- Remove exec bit from test data files
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull resolves #29 and may resolve #27 (it's difficult to test resolutions of issues to GitHub Actions without a way to run Actions locally—although there is some interesting development in that area).
Test Data
This pull includes unit + functional tests on the test data. When I run them, I get:
Related Issues