Kta 60 results after uploading data #10
Conversation
| return ( | ||
| <CenteredCardContent | ||
| title="Verification validated" | ||
| description="You can now close this window. The NEAR Foundation will contact you for the next steps." |
There was a problem hiding this comment.
This feels anti-climatic. We just asked someone to go through a bunch of hassle, and the result came back positive, so I think we should say something happier and more positive, especially since we're then bringing them the bad news that they have to wait longer on something else.
Maybe we want to say:
Congratulations! 🎉 We have verified your identity and are excited to move forward. NEAR Foundation will contact you for the next steps shortly. You can now close this window.
There was a problem hiding this comment.
Good one! Thanks a lot!
There was a problem hiding this comment.
I added some comments but nothing that stops me from approving.
Also, whenever you're submitting something that you want me to consider more carefully, either include screenshots and/or a 30-second video showing me what you want me to see, or tell me to build everything and run it myself (which I didn't do here since I assumed you'd tell me if anything needs that level of attention).
…xing magic number
|
@ryancwalsh just for your information: I updated the check state I was looking at the wrong place in the doc, thanks to the support I found this out, so I fixed it in this commit: ee5c509#diff-1130d586ce172f3f2f257e9b1875bd308f3335817f0a91f4df1d6ac8a93e101d |
| @@ -34,7 +34,8 @@ module.exports = { | |||
| 'react/jsx-props-no-spreading': 'off', | |||
| 'simple-import-sort/imports': 'error', | |||
| 'simple-import-sort/exports': 'error', | |||
| '@typescript-eslint/prefer-nullish-coalescing': 'warn', | |||
| '@typescript-eslint/prefer-nullish-coalescing': 'error', | |||
| 'no-magic-numbers': 'error', | |||
There was a problem hiding this comment.
Oh cool, I didn't know about this rule. 👍 I added to https://near-foundation.atlassian.net/jira/software/c/projects/ENG/boards/1?modal=detail&selectedIssue=ENG-156&quickFilter=1
A PR related to KTA-60 (check it out for more infos) but in short:
There is still something not very clear to know when to show the loading animation, and when to show the failing / restart message that is why I sent a message to the Onfido support.
Depending on the results I may have to update:
status: simplifiedStatus.get(check.status) ?? CheckResultsStatus.finished,maybe I would need to sendstatus: simplifiedStatus.get(check.status) ?? CheckResultsStatus.willTakeLonger)I will later write some E2E testings.