Kta 60 results after uploading data

.eslintrc.js

@@ -34,7 +34,8 @@ module.exports = {
     'react/jsx-props-no-spreading': 'off',
     'simple-import-sort/imports': 'error',
     'simple-import-sort/exports': 'error',
-    '@typescript-eslint/prefer-nullish-coalescing': 'warn',
+    '@typescript-eslint/prefer-nullish-coalescing': 'error',
+    'no-magic-numbers': 'error',
   },
   reportUnusedDisableDirectives: true, // https://eslint.org/docs/user-guide/configuring#report-unused-eslint-disable-comments
   settings: {

constants/index.tsx

@@ -1,4 +1,4 @@
-export const COOKIES_EXPIRATION_TIME = 60 * 60 * 24 * 30; // 30 days
+export const COOKIES_EXPIRATION_TIME = 2592000; // 30 days
 export const COOKIE_CHECK_ID_NAME = 'onfido-check-id';
 export const LOCALSTORAGE_USER_DATA_NAME = 'onfido-user-data';
 export const SHORT_POLLING_INTERVAL = 1000; // 1 second - Short polling applies when the check is in progress

pages/[key]/results.tsx

@@ -13,9 +13,11 @@ import { fetchCheckResults } from '../../services/apiService';
 import { CheckResultsStatus } from '../../types/CheckResults';
 
 const ResultsPage: NextPage = () => {
+  const NO_POLLING = 0;
+
   const [refetchInterval, setRefetchInterval] = useState(SHORT_POLLING_INTERVAL);
   const setLongPolling = () => setRefetchInterval(LONG_POLLING_INTERVAL);
-  const stopPolling = () => setRefetchInterval(0);
+  const stopPolling = () => setRefetchInterval(NO_POLLING);
 
   const { isLoading, error, data } = useQuery(['checkResults'], fetchCheckResults, {
     refetchInterval,

pages/api/check-results.ts

@@ -5,6 +5,7 @@ import { COOKIE_CHECK_ID_NAME } from '../../constants';
 import getOnfido from '../../helpers/onfido';
 import type { CheckResults } from '../../types/CheckResults';
 import { CheckResultsStatus } from '../../types/CheckResults';
+import { NOT_FOUND, SUCCESS } from '../../utils/statusCodes';
 
 const endpointName = 'check-results';
 
@@ -17,7 +18,7 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
   const check = await onfido.check.find(checkId);
 
   if (!checkId || !check) {
-    res.status(404).json({ isClear: null, status: CheckResultsStatus.notFound });
+    res.status(NOT_FOUND).json({ isClear: null, status: CheckResultsStatus.notFound });
     return;
   }
 
@@ -33,7 +34,7 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
   ]);
 
   // This need to be updated / improved depending on the answer from the support
-  res.status(200).json({
+  res.status(SUCCESS).json({
     isClear: check.result === null ? null : check.result === 'clear',
     status: simplifiedStatus.get(check.status) ?? CheckResultsStatus.finished,
   });

pages/api/create-check.ts

@@ -5,6 +5,7 @@ import type { NextApiRequest, NextApiResponse } from 'next';
 import { COOKIE_CHECK_ID_NAME, COOKIES_EXPIRATION_TIME } from '../../constants';
 import getOnfido from '../../helpers/onfido';
 import type ApplicantTokenPair from '../../types/ApplicantTokenPair';
+import { SERVER_ERROR, SUCCESS } from '../../utils/statusCodes';
 
 const reportNames = [
   'document',
@@ -40,7 +41,7 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
     res.setHeader('Set-Cookie', `${COOKIE_CHECK_ID_NAME}=${check.id}; Max-Age=${COOKIES_EXPIRATION_TIME}; Path=/`);
 
     console.log('Returning result', endpointName);
-    res.status(200).json(check);
+    res.status(SUCCESS).json(check);
   } catch (error: unknown | OnfidoApiError) {
     if (error instanceof OnfidoApiError) {
       // An error response was received from the Onfido API, extra info is available.
@@ -51,6 +52,6 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
       // No response was received for some reason e.g. a network error.
       console.error({ error });
     }
-    res.status(500).json(error);
+    res.status(SERVER_ERROR).json(error);
   }
 }

pages/api/generate-token.ts

@@ -1,27 +1,42 @@
 // Next.js API route support: https://nextjs.org/docs/api-routes/introduction
+import { OnfidoApiError } from '@onfido/api';
 import type { NextApiRequest, NextApiResponse } from 'next';
 
 import getOnfido from '../../helpers/onfido';
 import type ApplicantTokenPair from '../../types/ApplicantTokenPair';
+import { SERVER_ERROR, SUCCESS } from '../../utils/statusCodes';
 
 const endpointName = 'generate-token';
 
 const onfido = getOnfido();
 
-export default async function handler(req: NextApiRequest, res: NextApiResponse<ApplicantTokenPair>) {
-  const applicantProperties = req.body; // https://documentation.onfido.com/#applicant-object
-  console.log('Starting', endpointName);
-  const applicant = await onfido.applicant.create(applicantProperties);
+export default async function handler(req: NextApiRequest, res: NextApiResponse<ApplicantTokenPair | unknown>) {
+  try {
+    const applicantProperties = req.body; // https://documentation.onfido.com/#applicant-object
+    console.log('Starting', endpointName);
+    const applicant = await onfido.applicant.create(applicantProperties);
 
-  console.log('Applicant created', endpointName);
+    console.log('Applicant created', endpointName);
 
-  const sdkToken = await onfido.sdkToken.generate({
-    applicantId: applicant.id,
-    // referrer: 'http://localhost/**'
-    // crossDeviceUrl: "https://example.com"
-  });
-  const result = { applicantId: applicant.id, sdkToken };
+    const sdkToken = await onfido.sdkToken.generate({
+      applicantId: applicant.id,
+      // referrer: 'http://localhost/**'
+      // crossDeviceUrl: "https://example.com"
+    });
+    const result = { applicantId: applicant.id, sdkToken };
 
-  console.log('Returning result', endpointName);
-  res.status(200).json(result);
+    console.log('Returning result', endpointName);
+    res.status(SUCCESS).json(result);
+  } catch (error: unknown | OnfidoApiError) {
+    if (error instanceof OnfidoApiError) {
+      // An error response was received from the Onfido API, extra info is available.
+      console.error(error.message);
+      console.error(error.type);
+      console.error(error.isClientError());
+    } else {
+      // No response was received for some reason e.g. a network error.
+      console.error({ error });
+    }
+    res.status(SERVER_ERROR).json(error);
+  }
 }

utils/statusCodes.ts

@@ -0,0 +1,3 @@
+export const SUCCESS = 200;
+export const NOT_FOUND = 404;
+export const SERVER_ERROR = 500;