-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-appservice-irc: init at 0.3.1 #17213
Conversation
@Ralith, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers |
502b687
to
354a751
Compare
354a751
to
2507943
Compare
Is it really necessary to check in more than 10000 lines for a single package? |
I have very poor understanding of the npm packaging infrastructure, but this is certainly not the only package that includes a npm2nix generated file. I've experimented some but haven't been able to work out a way to get it to work with the default top-level one. If there's a better way, I'd love to hear about it. |
If nodejs stuff requires 10,000+ lines per package we seriously need to reconsider how things are done on that front. |
It looks like the NPM/nodejs infrastructure is being reworked in #16886 although recent activity is limited. Should this be blocked by it? |
As far as I'm concerned, yes. I'm not checking in 10,000+ lines of code for a single package. Somebody else might do it, however, my opinion is by no means authoritative. |
No progress for over a year. We will not merge this in the current form but feel free to reopen if things have improved. |
Motivation for this change
Provides IRC bridging for the Matrix chat network.
Things done
(nix.useChroot on NixOS,
or option
build-use-chroot
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)