-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace npm2nix generated package set by a node2nix generated package… #18151
Conversation
I discovered that there are still a bunch of NPM packages that are manually constructed, such as:
And one package having dependencies on NPM packages:
I'm currently trying to migrate them.... IMO some of them can be automatically deployed by node2nix with some additional overrides. Alternatively, I can leave the pkgs/top-level/node-packages* so that they don't break, and migrate these above listed packages to node2nix later... |
As a reminder: if you want to test the regeneration of the packages, you should install the development version of node2nix as it has not yet been officially released: https://github.com/svanderburg/node2nix/tree/fetchgit_fix deploy it as follows: $ nix-env -f release.nix -iA package.x86_64-linux |
Can confirm that the fetchgit_fix version of node2nix works for my git dependencies now. The rest seems good as usual. |
@svanderburg Continuing previous discussion, my concern is for things like #17213 which are not development projects, but applications which it is desirable to have available in nixpkgs, as users may not be developers at all. This goes double for services, where packages need to be referenced from a NixOS module. As it stands, it looks like even with the new infrastructure that PR will continue to languish because nobody wants to grow nixpkgs that much just for one package... |
3d616ad
to
b10d234
Compare
Closing because this has been integrated into master with a newly generated package set. |
I failed to add package
|
Motivation for this change
Another attempt: now a node2nix generated package set that tracks the master branch (future 16.09).
This PR is a preview -- when it is considered acceptable I will create a new node2nix release (version 1.0.1), regenerate and apply that change set upstream.
Things done
(nix.useChroot on NixOS,
or option
build-use-chroot
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)… set