glimpse: init at 0.1.2 #81563

ashkitten · 2020-03-02T22:35:07Z

Motivation for this change

requested in #77157

Things done

pkgs/applications/graphics/glimpse/default.nix

pkgs/applications/graphics/ufraw/default.nix

jtojnar · 2020-03-02T23:02:46Z

Did you decide to go with the plug-ins in the end?

ashkitten · 2020-03-02T23:09:52Z

i'm still on the edge about that, but i think we will be able to maintain compatibility with at least some of the plugins (g'mic and resynthesizer plugins are slated to be included by default in official glimpse packages) and i think if we can't reasonably maintain compatibility with certain plugins in the future we can still drop them.

ashkitten · 2020-03-03T00:01:15Z

all checks passed!

gloaming · 2020-03-03T09:26:30Z

pkgs/top-level/all-packages.nix

+  };
+
+  glimpse-with-plugins = callPackage ../applications/graphics/glimpse/wrapper.nix {
+    plugins = null; # All packaged plugins enabled, if not explicit plugin list supplied


Suggested change

plugins = null; # All packaged plugins enabled, if not explicit plugin list supplied

plugins = null; # All packaged plugins enabled, if no list supplied

this is also an issue with the documentation for gimp. should i add another commit to fix it for them as well?

Ah, of course. Yes, though it should go in another PR I think.

gloaming · 2020-03-03T09:29:35Z

The duplication here is a bit concerning. Would it not be better to override the gimp derivation where necessary?

ashkitten · 2020-03-03T17:49:58Z

i've decided to duplicate the derivation because while glimpse doesn't change much from its upstream at the moment, the plan is for it to evolve into an entirely separate project. it would be difficult to maintain if we packaged it as an override.

grahamc · 2020-04-11T22:05:31Z

pkgs/applications/graphics/glimpse/default.nix

+  enableParallelBuilding = true;
+
+  meta = with lib; {
+    description = "Fork of the GNU Image Manipulation Program";


Suggested change

description = "Fork of the GNU Image Manipulation Program";

description = "aN OPEN SOURCE IMAGE EDITOR BASED ON THE gnu iMAGE mANIPULATION pROGRAM";

longDescription = ''

Glimpse is an open source image editor based on the GNU Image Manipulation Program. The goal is to experiment with new ideas and expand the use of free software.

'';

maybe?

sure, i just took that description from the description on https://github.com/glimpse-editor/Glimpse

grahamc · 2020-04-11T22:14:41Z

after building it, I got a segfault, possibly related to this:

Glimpse-Warning: Bad interpreter referenced in interpreter file /nix/store/f30pn34ljwppl5bsrarszgdk4bly4p9b-glimpse-0.1.2/lib/glimpse/2.0/interpreters/pygimp.interp: python2

Glimpse-Warning: Bad binary format string in interpreter file /nix/store/f30pn34ljwppl5bsrarszgdk4bly4p9b-glimpse-0.1.2/lib/glimpse/2.0/interpreters/pygimp.interp

ashkitten · 2020-04-11T22:16:38Z

building it I got a segfault, possibly related to this:

Glimpse-Warning: Bad interpreter referenced in interpreter file /nix/store/f30pn34ljwppl5bsrarszgdk4bly4p9b-glimpse-0.1.2/lib/glimpse/2.0/interpreters/pygimp.interp: python2

Glimpse-Warning: Bad binary format string in interpreter file /nix/store/f30pn34ljwppl5bsrarszgdk4bly4p9b-glimpse-0.1.2/lib/glimpse/2.0/interpreters/pygimp.interp

a segfault while building? i've never gotten that before... also, iirc the gimp build has those same warnings

grahamc · 2020-04-11T22:17:08Z

oops, missed a word :)

grahamc · 2020-04-11T22:17:27Z

Glimpse version 2.10.12
git-describe: f32663b334
C compiler:
gcc-9.3.0
using GEGL version 0.4.22 (compiled against version 0.4.22)
using GLib version 2.64.1 (compiled against version 2.64.1)
using GdkPixbuf version 2.40.0 (compiled against version 2.40.0)
using GTK+ version 2.24.32 (compiled against version 2.24.32)
using Pango version 1.44.7 (compiled against version 1.44.7)
using Fontconfig version 2.12.6 (compiled against version 2.12.6)
using Cairo version 1.16.0 (compiled against version 1.16.0)

```
> fatal error: Segmentation fault

Stack trace:
```
/nix/store/f30pn34ljwppl5bsrarszgdk4bly4p9b-glimpse-0.1.2/lib/libgimpbase-2.0.so.0(gimp_stack_trace_print+0x398)[0x7f532881f418]
./result/bin/glimpse[0x4ac6e0]
./result/bin/glimpse[0x4acb08]
./result/bin/glimpse[0x4ad199]
/nix/store/an6bdv4phxsz14q2sk57iscl2dc7bnj1-glibc-2.30/lib/libpthread.so.0(+0x12f70)[0x7f5327c22f70]
./result/bin/glimpse(gimp_param_spec_layer_id+0x64)[0x82be64]
./result/bin/glimpse(gimp_pdb_compat_param_spec+0x1c7)[0x746aa7]
./result/bin/glimpse(gimp_plug_in_handle_message+0x11a9)[0x7534e9]
./result/bin/glimpse(gimp_plug_in_manager_call_query+0x191)[0x761b41]
./result/bin/glimpse(gimp_plug_in_manager_restore+0x796)[0x759ab6]
./result/bin/glimpse[0x77776d]
/nix/store/idqwnnq6a1mzci2fi2rc26wqz9s0aa4a-glib-2.64.1/lib/libgobject-2.0.so.0(g_closure_invoke+0x1a2)[0x7f5327f9aec2]
/nix/store/idqwnnq6a1mzci2fi2rc26wqz9s0aa4a-glib-2.64.1/lib/libgobject-2.0.so.0(+0x2753e)[0x7f5327fad53e]
/nix/store/idqwnnq6a1mzci2fi2rc26wqz9s0aa4a-glib-2.64.1/lib/libgobject-2.0.so.0(g_signal_emit_valist+0xbdf)[0x7f5327fb8fef]
/nix/store/idqwnnq6a1mzci2fi2rc26wqz9s0aa4a-glib-2.64.1/lib/libgobject-2.0.so.0(g_signal_emit+0x8f)[0x7f5327fb997f]
./result/bin/glimpse(gimp_restore+0x102)[0x776cf2]
./result/bin/glimpse(app_run+0x49b)[0x4ac00b]
./result/bin/glimpse(main+0x37e)[0x4ab7be]
/nix/store/an6bdv4phxsz14q2sk57iscl2dc7bnj1-glibc-2.30/lib/libc.so.6(__libc_start_main+0xeb)[0x7f5327a74d8b]
./result/bin/glimpse(_start+0x2a)[0x4ab94a]

````

ashkitten · 2020-04-11T23:29:20Z

it works fine for me, even with those interpreter warnings you showed before

glittershark · 2020-04-13T01:31:55Z

I've been using this via @ashkitten's fork for a couple weeks now and it's been working great for me

glittershark · 2020-04-13T01:32:14Z

albeit very lightly, mostly for cropping and combining screenshots

gloaming · 2020-04-16T09:58:45Z

i've decided to duplicate the derivation because while glimpse doesn't change much from its upstream at the moment, the plan is for it to evolve into an entirely separate project.

Hmm, this doesn't seem quite right - from the FAQ:

Is forking the project a duplication of effort?
No, because we are focusing specifically on the user experience and marketing, not on the underlying functionality of the software itself.
That is why we intend to periodically rebase on tagged versions of the GNU Image Manipulation Program, and then port our changes to it each time.

it would be difficult to maintain if we packaged it as an override.

This may still be true though.

bbjubjub2494 · 2020-07-02T19:19:03Z

I ran into the segfault too, but there's already a patch for it in upstream v0.1.2r2. There's no download for that release but it's easy enough to backport.

5c581ac

jtojnar · 2020-07-06T00:27:04Z

The interpreter warning has been fixed in GIMP in #92228

glimpse: patch segfault

erictapen · 2020-11-09T19:37:20Z

I'd like to help bring this forward.
Current PR is incompatible with fontconfig from unstable/20.09, so I rebased and bumped to Glimpse 0.2.0 in erictapen@8f5c545.

So far this seems to run fine for me; No errors on startup, I was able to draw some basic stuff.

@ashkitten could you rebase and bump? I could also open a new PR if you'd like.

ashkitten · 2020-11-09T21:00:19Z

@erictapen i don't have the bandwidth for this rn so if you could take over that'd be fantastic

erictapen · 2020-11-10T09:50:41Z

Sure! Closing in favor of #103288.

ashkitten mentioned this pull request Mar 2, 2020

package request: Glimpse (re-branding of GIMP) #77157

Closed

jtojnar reviewed Mar 2, 2020

View reviewed changes

pkgs/applications/graphics/glimpse/default.nix Outdated Show resolved Hide resolved

pkgs/applications/graphics/ufraw/default.nix Show resolved Hide resolved

ufraw: don't hardcode gimp plugin dir

32c6b6f

ashkitten force-pushed the init-glimpse branch from 0f0464c to e00fa72 Compare March 2, 2020 22:48

ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 2, 2020

ofborg bot requested a review from gloaming March 2, 2020 22:59

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Mar 2, 2020

glimpse: init at 0.1.2

bf40cdc

ashkitten force-pushed the init-glimpse branch from e00fa72 to bf40cdc Compare March 2, 2020 23:31

gloaming reviewed Mar 3, 2020

View reviewed changes

grahamc reviewed Apr 11, 2020

View reviewed changes

glimpse: patch segfault

5c581ac

bbjubjub2494 mentioned this pull request Jul 2, 2020

glimpse: patch segfault ashkitten/nixpkgs#1

Merged

Merge pull request #1 from lourkeur/glimpse

fad2b09

glimpse: patch segfault

ofborg bot requested a review from gloaming July 8, 2020 21:06

rossabaker added a commit to rossabaker/cromulent that referenced this pull request Sep 26, 2020

Add glimpse: NixOS/nixpkgs#81563

b3178fc

erictapen mentioned this pull request Nov 10, 2020

glimpse: init at 0.2.0 #103288

Merged

10 tasks

erictapen closed this Nov 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

glimpse: init at 0.1.2 #81563

glimpse: init at 0.1.2 #81563

ashkitten commented Mar 2, 2020

jtojnar commented Mar 2, 2020

ashkitten commented Mar 2, 2020

ashkitten commented Mar 3, 2020

gloaming Mar 3, 2020

ashkitten Mar 3, 2020

gloaming Apr 16, 2020

gloaming commented Mar 3, 2020

ashkitten commented Mar 3, 2020

grahamc Apr 11, 2020 •

edited

Loading

ashkitten Apr 11, 2020

grahamc commented Apr 11, 2020 •

edited

Loading

ashkitten commented Apr 11, 2020 •

edited

Loading

grahamc commented Apr 11, 2020

grahamc commented Apr 11, 2020

ashkitten commented Apr 11, 2020

glittershark commented Apr 13, 2020

glittershark commented Apr 13, 2020

gloaming commented Apr 16, 2020

bbjubjub2494 commented Jul 2, 2020 •

edited

Loading

jtojnar commented Jul 6, 2020

erictapen commented Nov 9, 2020 •

edited

Loading

ashkitten commented Nov 9, 2020

erictapen commented Nov 10, 2020

	plugins = null; # All packaged plugins enabled, if not explicit plugin list supplied
	plugins = null; # All packaged plugins enabled, if no list supplied

-    description = "Fork of the GNU Image Manipulation Program";
+    description = "aN OPEN SOURCE IMAGE EDITOR BASED ON THE gnu iMAGE mANIPULATION pROGRAM";
+    longDescription = ''
+      Glimpse is an open source image editor based on the GNU Image Manipulation Program. The goal is to experiment with new ideas and expand the use of free software.
+    '';

glimpse: init at 0.1.2 #81563

glimpse: init at 0.1.2 #81563

Conversation

ashkitten commented Mar 2, 2020

Motivation for this change

Things done

jtojnar commented Mar 2, 2020

ashkitten commented Mar 2, 2020

ashkitten commented Mar 3, 2020

gloaming Mar 3, 2020

Choose a reason for hiding this comment

ashkitten Mar 3, 2020

Choose a reason for hiding this comment

gloaming Apr 16, 2020

Choose a reason for hiding this comment

gloaming commented Mar 3, 2020

ashkitten commented Mar 3, 2020

grahamc Apr 11, 2020 • edited Loading

Choose a reason for hiding this comment

ashkitten Apr 11, 2020

Choose a reason for hiding this comment

grahamc commented Apr 11, 2020 • edited Loading

ashkitten commented Apr 11, 2020 • edited Loading

grahamc commented Apr 11, 2020

grahamc commented Apr 11, 2020

ashkitten commented Apr 11, 2020

glittershark commented Apr 13, 2020

glittershark commented Apr 13, 2020

gloaming commented Apr 16, 2020

bbjubjub2494 commented Jul 2, 2020 • edited Loading

jtojnar commented Jul 6, 2020

erictapen commented Nov 9, 2020 • edited Loading

ashkitten commented Nov 9, 2020

erictapen commented Nov 10, 2020

grahamc Apr 11, 2020 •

edited

Loading

grahamc commented Apr 11, 2020 •

edited

Loading

ashkitten commented Apr 11, 2020 •

edited

Loading

bbjubjub2494 commented Jul 2, 2020 •

edited

Loading

erictapen commented Nov 9, 2020 •

edited

Loading