Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gimp: Fix plug-in interpreter paths #92228

Merged
merged 2 commits into from
Jul 5, 2020
Merged

gimp: Fix plug-in interpreter paths #92228

merged 2 commits into from
Jul 5, 2020

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jul 3, 2020 •
edited
Loading

Motivation for this change

See #60937 (comment) and #87883

I can confirm that the warnings are no longer shown and Filter → Enhance → Heal selection opens the dialogue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jluttine, @rkoe, @shirona

jtojnar added 2 commits July 3, 2020 21:07
@jtojnar
gimp: Fix interpreter path
3b701aa 
GIMP uses python interpreter specified in pygimp.interp file for running Python plug-ins,
so any Python related wrapping is useless. It will pick up and use the python from build PATH.

Let’s use a python environment containing pygtk, which is needed by many plug-ins.

Closes: NixOS#87883
@jtojnar
gimp: Hardcode interpreter paths
64ec4fd 
The E (extension) line in pygimp.interp prints the following warnings:

GIMP-Warning: Bad interpreter referenced in interpreter file /nix/store/5c91dah385gn70blsn6i5rzncqj3ks0y-gimp-with-plugins-2.10.18/lib/gimp/2.0/interpreters/pygimp.interp: python2
GIMP-Warning: Bad binary format string in interpreter file /nix/store/5c91dah385gn70blsn6i5rzncqj3ks0y-gimp-with-plugins-2.10.18/lib/gimp/2.0/interpreters/pygimp.interp

This means that the py extension will not be registered when python2 is not in PATH. To prevent this, let’s hardcode the absolute python2 path.

NixOS#60937 (comment)

Closes: NixOS#60937
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jul 3, 2020
@jtojnar jtojnar merged commit 9925e90 into NixOS:master Jul 5, 2020
@jtojnar jtojnar deleted the gimp-interp branch July 5, 2020 03:45
@jtojnar jtojnar mentioned this pull request Jul 6, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtojnar