Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

px4_fmu-v4pro Fix PX4IO firmware upgrade #14072

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Jan 30, 2020

The PX4IO was responding but the RX DMA stay borke

This fixes USART6 RX DMA Assignment

@davids5 davids5 requested review from dagar and LorenzMeier January 30, 2020 20:48
@dagar dagar added the bug label Jan 30, 2020
@dagar
Copy link
Member

dagar commented Jan 30, 2020

Thanks David. I'd like to take this as an opportunity to get the test rack into a state where it can actually catch trivial things like this. All boards on the test rack routinely get stuck in a state where the px4io is unrecoverable.

@dagar
Copy link
Member

dagar commented Jan 30, 2020

@dagar dagar merged commit 514e1a3 into master Jan 30, 2020
@dagar dagar deleted the master_px4pro_px4io_fix branch January 30, 2020 21:20
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #14072 into master will decrease coverage by 1.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14072      +/-   ##
==========================================
- Coverage   54.59%   52.92%   -1.67%     
==========================================
  Files         605      605              
  Lines       51371    51368       -3     
==========================================
- Hits        28046    27189     -857     
- Misses      23325    24179     +854
Flag Coverage Δ
#mavsdk ?
#python 3.15% <ø> (ø) ⬆️
#sitl_mission_FW 29.41% <ø> (-0.02%) ⬇️
#sitl_mission_MC_box 29.74% <ø> (-0.05%) ⬇️
#sitl_mission_MC_offboard_att 28.21% <ø> (-0.05%) ⬇️
#sitl_mission_MC_offboard_pos 28.5% <ø> (+0.01%) ⬆️
#sitl_mission_Rover 26.22% <ø> (-0.02%) ⬇️
#sitl_mission_VTOL_standard 33.94% <ø> (?)
#sitl_mission_VTOL_tailsitter 33.92% <ø> (-0.04%) ⬇️
#sitl_python_FW 29.49% <ø> (-0.02%) ⬇️
#sitl_python_MC_box 29.82% <ø> (-0.05%) ⬇️
#sitl_python_MC_offboard_att 28.28% <ø> (-0.05%) ⬇️
#sitl_python_MC_offboard_pos 28.58% <ø> (+0.01%) ⬆️
#sitl_python_Rover 26.31% <ø> (-0.02%) ⬇️
#sitl_python_VTOL_standard 34.01% <ø> (-40.68%) ⬇️
#sitl_python_VTOL_tailsitter 33.98% <ø> (-0.04%) ⬇️
#unittest 34.89% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
...b/flight_tasks/tasks/Descend/FlightTaskDescend.cpp 0% <0%> (-83.34%) ⬇️
src/modules/navigator/takeoff.cpp 3.92% <0%> (-76.48%) ⬇️
...flight_tasks/tasks/Failsafe/FlightTaskFailsafe.cpp 0% <0%> (-73.92%) ⬇️
src/modules/navigator/rtl.cpp 14.46% <0%> (-44.22%) ⬇️
...lib/flight_tasks/tasks/Manual/FlightTaskManual.cpp 0% <0%> (-38.89%) ⬇️
src/modules/navigator/loiter.cpp 8.16% <0%> (-38.78%) ⬇️
src/modules/simulator/simulator_mavlink.cpp 59.31% <0%> (-18.85%) ⬇️
src/modules/mavlink/mavlink_timesync.cpp 72.5% <0%> (-15%) ⬇️
...der/Arming/PreFlightCheck/checks/airspeedCheck.cpp 59.25% <0%> (-14.82%) ⬇️
..._tasks/tasks/Utility/ManualVelocitySmoothingXY.hpp 78.57% <0%> (-14.29%) ⬇️
... and 34 more

@dagar
Copy link
Member

dagar commented Jan 30, 2020

I'm also still trying to figure out why the redefinition wasn't a compile time warning.

@davids5
Copy link
Member Author

davids5 commented Jan 31, 2020

@dagar

Would you please send me the image from 0 to 0xffff as a bin file extracted from the PX4IO on the V4PRO of the test rack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants