fix(tiflash): fix script path #3216
Conversation
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
From the pull request, it seems that the changes are related to fixing the script path in the CI/CD pipeline for the TiFlash project. Specifically, the directory name was modified and the script paths were updated accordingly. One potential problem could be if there are other scripts or files that reference the old directory name, they may break after this change. It would be good to check if there are any other dependencies that need to be updated as well. As for fixing suggestions, it would be helpful to add some comments to the code to explain why the changes were made and what dependencies were updated. Additionally, it would be good to perform some testing to ensure that the CI/CD pipeline still runs smoothly after the changes. If any issues arise, they should be addressed promptly. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on the title and description of the pull request, it seems that the only change made was to modify the path to the script files. Specifically, the directory name was changed from "release-centos7-llvm" to "release-linux-llvm". There don't seem to be any potential problems with this change as it is only a path modification. However, it is important to ensure that the new path is correct and that the scripts can still be executed without any issues. As for fixing suggestions, it would be helpful to add more context to the pull request description to explain why the directory name was changed and if any other modifications were made. Additionally, it might be useful to verify that the scripts are still functioning as expected and to update any relevant documentation or instructions to reflect the new path. |
update the build script path. Ref #3216 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
|
duplicate with #3219 |
update the build script path. Ref #3216 Signed-off-by: wuhuizuo <wuhuizuo@126.com> Signed-off-by: wuhuizuo <wuhuizuo@126.com>
In pingcap/tiflash#9587, we modify the directory name.