Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgarde all docker images to use rocky linux 8 #9587

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Nov 6, 2024

What problem does this PR solve?

Issue Number: close #9586

Problem Summary:

What is changed and how it works?

*: upgarde all docker images to use rocky linux 8

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 6, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 7, 2024

/hold

It will affect the build instructors used in CI/CD flows.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2024
Lloyd-Pottiger and others added 2 commits November 7, 2024 11:39
Co-authored-by: JaySon <tshent@qq.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
wuhuizuo added a commit to PingCAP-QE/artifacts that referenced this pull request Nov 7, 2024
With the new version of tiflash builder to improve the performance of the artifacts.

Ref: pingcap/tiflash#9587

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot bot pushed a commit to PingCAP-QE/artifacts that referenced this pull request Nov 7, 2024
With the new version of tiflash builder to improve the performance of
the artifacts.

Ref: pingcap/tiflash#9587

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 03:25:54.118088467 +0000 UTC m=+1097866.957244013: ☑️ agreed by JinheLin.
  • 2024-11-08 06:10:40.282412349 +0000 UTC m=+1194153.121567896: ☑️ agreed by JaySon-Huang.

wuhuizuo added a commit to PingCAP-QE/artifacts that referenced this pull request Nov 8, 2024
Ref pingcap/tiflash#9587, it changes the build script paths.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Lloyd-Pottiger and others added 2 commits November 8, 2024 15:19
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@purelind
Copy link
Collaborator

purelind commented Nov 8, 2024

/retest

wuhuizuo added a commit to PingCAP-QE/artifacts that referenced this pull request Nov 8, 2024
Ref pingcap/tiflash#9587, it changes the build
script paths.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 8, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 8, 2024

/cherry-pick release-8.5

@ti-chi-bot
Copy link
Member

@wuhuizuo: once the present PR merges, I will cherry-pick it on top of release-8.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 6f238a6 into pingcap:master Nov 8, 2024
5 checks passed
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-8.5: #9598.

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Lloyd-Pottiger Lloyd-Pottiger deleted the upgarde-build-image branch November 9, 2024 11:58
ti-chi-bot bot pushed a commit that referenced this pull request Nov 11, 2024
close #9586

*: upgarde all docker images to use rocky linux 8

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

Co-authored-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
Co-authored-by: JaySon <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OALP perftest tpch-2tiflash-50g& tpch-tiflash-50g result with total-avg-latency raise 15-20%
6 participants