This repository was archived by the owner on Jul 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not be merged until Qiskit/qiskit#5499 is merged |
# Conflicts: # qiskit/providers/ibmq/experiment/experimentservice.py
mriedem
reviewed
Jul 27, 2021
pip install -U -c constraints.txt -r requirements-dev.txt | ||
pip install -c constraints.txt -e . | ||
- name: Run Tests | ||
run: make runtime_integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be experiment_integration
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to push my changes before merging it 🤦♀️
mriedem
added a commit
to mriedem/qiskit-ibmq-provider
that referenced
this pull request
Jul 27, 2021
Follow up to Qiskit#945
Merged
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the experiment service to use
ExperimentData
,AnalysisResult
, andExperimentService
classes inqiskit-terra
. This allows the newqiskit-experiments
package to create experiments without requiring access to IBM Quantum.Details and comments
Closes #873, #854.