Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ibex-2.8.6 #15872

Closed
4 of 5 tasks
soonhokong opened this issue Oct 4, 2021 · 9 comments
Closed
4 of 5 tasks

Upgrade to ibex-2.8.6 #15872

soonhokong opened this issue Oct 4, 2021 · 9 comments
Assignees
@soonhokong
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: backlog

Comments

@soonhokong
Copy link
Contributor

soonhokong commented Oct 4, 2021 •
edited by jwnimmer-tri
Loading

We've found an issue with the current version of ibex (ibex-2.7.4) (see #15789). We will move to ibex-2.8.6 to resolve the problem. For the record, ibex>=2.8.7 dropped the CLP support which is the only freely available LP solver (up-to ibex-2.8.6). There is an attempt to bring the CLP support back to ibex, but it's still in-progress.

Action Items:

  • Prepare .deb for ibex-2.8.6.
  • Provide ibex@2.8.6 in https://github.com/RobotLocomotion/homebrew-director/tree/master/Formula. Note that this requires generating homebrew bottles.
  • Drake needs to use a version of dReal which is compatible with ibex-2.8.6.
  • Need to update setup scripts to use ibex-2.8.6.
  • IbexSolver implementation needs a few changes to be compatible with ibex-2.8.6

/cc @BetsyMcPhail for heads-up for infrastructure updates.
/cc @RussTedrake
@soonhokong soonhokong added unused team: robot locomotion group component: build system Bazel, CMake, dependencies, memory checkers, linters labels Oct 4, 2021
@soonhokong soonhokong self-assigned this Oct 4, 2021
@jwnimmer-tri
Copy link
Collaborator

Prepare .deb for ibex-2.8.6.

Where is the deb rebuilding process documented, or more specifically, where does the source code for that *.deb originate from? Since the code is LGPL, we need to ensure that we can provide the sources anytime we provide precompiled binaries.

@soonhokong
Copy link
Contributor Author

It will be uploaded to https://launchpad.net/~dreal/+archive/ubuntu/dreal/+packages where you can download source code as well.

@RussTedrake
Copy link
Contributor

RussTedrake commented Oct 20, 2021 •
edited
Loading

ftr -- i have ibex 2.8.6 building from source in bazel now. will PR it shortly.

@jwnimmer-tri jwnimmer-tri mentioned this issue Oct 21, 2021
Closed
RussTedrake added a commit to RussTedrake/drake that referenced this issue Oct 23, 2021
@RussTedrake
Build ibex 2.8.6 from source
5b15add 
Resolves RobotLocomotion#13219 and RobotLocomotion#15872
Relevant to RobotLocomotion#15946
RussTedrake added a commit to RussTedrake/drake that referenced this issue Oct 23, 2021
@RussTedrake
Build ibex 2.8.6 from source
d26adfb 
Resolves RobotLocomotion#13219 and RobotLocomotion#15872
Relevant to RobotLocomotion#15946

Includes patches to dreal and IbexSolver from @soonhokong.
@RussTedrake RussTedrake mentioned this issue Oct 23, 2021
Merged
RussTedrake added a commit to RussTedrake/drake that referenced this issue Oct 23, 2021
@RussTedrake
Build ibex 2.8.6 from source
316db09 
Resolves RobotLocomotion#13219 and RobotLocomotion#15872
Relevant to RobotLocomotion#15946
Should (finally) get RobotLocomotion#15789 unstuck.

Includes a patch to dReal and updates to IbexSolver from @soonhokong.

Co-authored-by: Soonho Kong soonho.kong@gmail.com
RussTedrake added a commit to RussTedrake/drake that referenced this issue Oct 23, 2021
@RussTedrake @soonhokong
Build ibex 2.8.6 from source
492ab7a 
Resolves RobotLocomotion#13219 and RobotLocomotion#15872
Relevant to RobotLocomotion#15946
Should (finally) get RobotLocomotion#15789 unstuck.

Includes a patch to dReal and updates to IbexSolver from @soonhokong.

Co-authored-by: Soonho Kong <soonho.kong@gmail.com>
RussTedrake added a commit to RussTedrake/drake that referenced this issue Oct 24, 2021
@RussTedrake @soonhokong
Build ibex 2.8.6 from source
ac22831 
Resolves RobotLocomotion#13219 and RobotLocomotion#15872
Relevant to RobotLocomotion#15946
Should (finally) get RobotLocomotion#15789 unstuck.

Includes a patch to dReal and updates to IbexSolver from @soonhokong.

Co-authored-by: Soonho Kong <soonho.kong@gmail.com>
@jwnimmer-tri
Copy link
Collaborator

The remaining work here is ... to upgrade dReal and remove Drake's local patch file?

@soonhokong
Copy link
Contributor Author

Yes, I will ping here when it’s ready.

@jwnimmer-tri
Copy link
Collaborator

The latest tag to dReal is 4.21.06.2. I think we'll need a new version number tag, before we can upgrade.

@mwoehlke-kitware
Copy link
Contributor

Just to add a wrinkle... the currently-used-by-drake version of ibex does not compile on Jammy.

@mwoehlke-kitware
Copy link
Contributor

See also ibex-team/ibex-lib#461; it appears upstream has re-added CLP support?

@jwnimmer-tri jwnimmer-tri mentioned this issue Oct 21, 2022
Merged
@jwnimmer-tri
Copy link
Collaborator

Not relevant anymore, per #18156.

@jwnimmer-tri jwnimmer-tri closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soonhokong soonhokong

Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@soonhokong @RussTedrake @mwoehlke-kitware @jwnimmer-tri