Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Externals March 2025 #22666

Open
8 tasks done
nicolecheetham opened this issue Feb 25, 2025 · 5 comments
Open
8 tasks done

Upgrade Externals March 2025 #22666

nicolecheetham opened this issue Feb 25, 2025 · 5 comments
Assignees
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters type: feature request

Comments

@jwnimmer-tri
Copy link
Collaborator

BTW Please also upgrade us to use the just-released https://github.com/bazelbuild/bazel/releases/tag/8.1.1. Probably as a separate PR just to be safe.

@nicolecheetham
Copy link
Contributor Author

@jwnimmer-tri The semi-automatic script no longer works when upgrading rust_toolchain. It specifically outputs an error message stating WORKSPACE has to be enabled for sync command to work, run with --enable_workspace.

In the rust_toolchain upgrade.py file I proceeded to add the flag to the sync command on line 34. However, it then warns workspace support will be removed in the near future, mentions switching to MODULE style externals like bzlmod, and then errors out as the subprocess returned a non-zero exit status.

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Feb 28, 2025

Okay, please file a new issue and assign to me. Thanks for catching it!

Edit: => #22684

@nicolecheetham
Copy link
Contributor Author

@jwnimmer-tri How does one use bazel run //tools/workspace:new_release -- --lint --commit foo to upgrade two externals? I am currently trying to upgrade clarabel_cpp_internal and crate_universe but I am only seeing the latter.

@jwnimmer-tri
Copy link
Collaborator

You can list multiple names on the command line at once, e.g.:

jwnimmer@call-cps:~/jwnimmer-tri/drake$ bazel run //tools/workspace:new_release -- --lint --commit spral_internal suitesparse_internal
...
INFO: All external dependencies for the requested targets fetched successfully.
Missing metadata for suitesparse_internal
Upgrading suitesparse_internal from v7.9.0 to v7.10.0
Downloading new archive...
Populating repository cache ...
...
INFO: All external dependencies for the requested targets fetched successfully.
************************************************************************
Done.  Changes for suitesparse_internal were committed.
Be sure to review the changes and amend the commit if needed.
************************************************************************
Upgrading spral_internal from v2025.01.08 to v2025.03.03
Downloading new archive...
Populating repository cache ...
...
INFO: All external dependencies for the requested targets fetched successfully.
************************************************************************
Done.  Changes for spral_internal were committed.
Be sure to review the changes and amend the commit if needed.
************************************************************************
...
Executed 294 out of 7440 tests: 7440 tests pass.

But if two packages are already declared as a cohort, they will automatically both happen even if you ask for just one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters type: feature request
Development

No branches or pull requests

2 participants