Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Upgrade spral_internal to latest release v2025.03.03 #22693

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

nicolecheetham
Copy link
Contributor

@nicolecheetham nicolecheetham commented Mar 3, 2025

Towards: #22666

Edit: Once approved, this should be squash-and-merged (not curated).


This change is Reviewable

@nicolecheetham nicolecheetham added the release notes: fix This pull request contains fixes (no new features) label Mar 3, 2025
@nicolecheetham nicolecheetham marked this pull request as ready for review March 3, 2025 18:14
@jwnimmer-tri jwnimmer-tri self-assigned this Mar 3, 2025
@jwnimmer-tri jwnimmer-tri added status: single reviewer ok https://drake.mit.edu/reviewable.html priority: low labels Mar 3, 2025
@jwnimmer-tri jwnimmer-tri removed their assignment Mar 3, 2025
@jwnimmer-tri
Copy link
Collaborator

+@ggould-tri for both reviews per schedule (tomorrow), please.

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)

@ggould-tri ggould-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Mar 4, 2025
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: squashing now) (looks like an autosquash was missed)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee ggould-tri(platform)

@ggould-tri ggould-tri merged commit f41d295 into RobotLocomotion:master Mar 4, 2025
10 checks passed
@jwnimmer-tri
Copy link
Collaborator

(looks like an autosquash was missed)

I tend to use the autosquash spelling even when just committing by hand, to remind me that the commit isn't suppose to remain intact -- but I never force-push to other people's PRs, so it's maybe misleading.

@jwnimmer-tri jwnimmer-tri added release notes: none This pull request should not be mentioned in the release notes and removed release notes: fix This pull request contains fixes (no new features) labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants