Meshcat AddSlider and SetSliderValue return rounded/truncated value #22495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are computing this anyhow, so it is no burden to return them. And it turns out to be useful for my follow-up PR to JointSliders which has to reason explicitly about the rounding happening in the sliders.
RussTedrake
added
the
release notes: feature
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee ggould-tri(platform)
ggould-tri
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees ggould-tri(platform),joemasterjohn
jwnimmer-tri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are computing this anyhow, so it is no burden to return them. And it turns out to be useful for my follow-up PR to JointSliders which has to reason explicitly about the rounding happening in the sliders.
+@joemasterjohn for feature review, please.
This change is