Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Upgrade openusd_internal to latest release v25.02 #22568

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

nicolecheetham
Copy link
Contributor

@nicolecheetham nicolecheetham commented Jan 30, 2025

Towards: #22536


This change is Reviewable

@nicolecheetham nicolecheetham added the release notes: fix This pull request contains fixes (no new features) label Jan 30, 2025
@nicolecheetham nicolecheetham marked this pull request as ready for review January 30, 2025 15:55
@jwnimmer-tri
Copy link
Collaborator

I'll let @rpoyner-tri take this one. Given NVidia's radio silence, possibly the right answer here is to mark commit_pin = True instead, and decline to keep upgrading it until the USD parsing project unpauses?

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)


a discussion (no related file):
I believe the offered fixup is correct. The previously patched file has been moved or rewritten, and include statements in all similarly named files use the correct syntax.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri or delegate for second review.

:lgtm: with co-author caveats

Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)

@jwnimmer-tri
Copy link
Collaborator

The build isn't all the way fixed yet (see Jenkins errors).

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)

@jwnimmer-tri jwnimmer-tri merged commit fe3014f into RobotLocomotion:master Jan 30, 2025
7 of 9 checks passed
@jwnimmer-tri jwnimmer-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Jan 30, 2025
@nicolecheetham nicolecheetham deleted the upgrade-openusd branch February 26, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants