Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding different viewports to e2e testing #1321

Closed
bgambocjaviniar opened this issue Feb 15, 2019 · 3 comments
Closed

Adding different viewports to e2e testing #1321

bgambocjaviniar opened this issue Feb 15, 2019 · 3 comments
Labels
e2e-tests
Milestone
1903-27 (0.1.0-al...

Comments

@bgambocjaviniar
Copy link
Contributor

bgambocjaviniar commented Feb 15, 2019 •
edited
Loading

Our e2e tests only tests the desktop version of our application, but we do not know if it works perfectly for different viewports. Therefore, it would be best to include 'mobile' versions in order to not miss any bugs or errors.

Nightly builds (or at will), because essentially we're running the tests 6 times.
Update DoD as well.
@KateChuen
Copy link
Contributor

KateChuen commented Feb 26, 2019 •
edited
Loading

Yes, totally agree with that. Add viewports for:
[ ] small desktop
[ ] wide desktop
[ ] tablet
[ ] small mobile (for eg, iphone 5)
[ ] big mobile (for eg, iphone 7+)
And maybe go one step further, and add viewport for
[ ] landscape orientation on mobile

@Xymmer Xymmer added this to the ALPHA-0 milestone Feb 28, 2019
@Xymmer
Copy link
Contributor

Xymmer commented Feb 28, 2019

For this ticket, the goal is to make sure that we are running all e2e tests at different viewports.

If tests fail: create bug or update e2e test.
Then we do a bug triage based on found issues.

Future: what new e2e tests should be created that are specific to mobile?
Or if a modification to an e2e is big, just create the ticket and we'll refine together.

@bgambocjaviniar bgambocjaviniar removed their assignment Mar 11, 2019
@bgambocjaviniar bgambocjaviniar mentioned this issue Mar 11, 2019
Merged
@bgambocjaviniar
Copy link
Contributor Author

PR #1615

bgambocjaviniar added a commit that referenced this issue Mar 11, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
cdb7940
@Xymmer Xymmer modified the milestones: ALPHA-0, BETA-0 Mar 11, 2019
@bgambocjaviniar bgambocjaviniar self-assigned this Mar 12, 2019
bgambocjaviniar added a commit that referenced this issue Mar 12, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
205ca2f
@bgambocjaviniar bgambocjaviniar removed their assignment Mar 14, 2019
bgambocjaviniar added a commit that referenced this issue Mar 14, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
2fd2979
@KateChuen KateChuen self-assigned this Mar 15, 2019
KateChuen added a commit that referenced this issue Mar 18, 2019
@KateChuen
Merge branch 'develop' into feature/GH-1321
9f47444
bgambocjaviniar added a commit that referenced this issue Mar 18, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
18a7e70
bgambocjaviniar added a commit that referenced this issue Mar 19, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
56bf6da
KateChuen added a commit that referenced this issue Mar 19, 2019
@KateChuen
Merge branch 'develop' into feature/GH-1321
d59728c
KateChuen added a commit that referenced this issue Mar 20, 2019
@KateChuen
Merge branch 'develop' into feature/GH-1321
e723844
bgambocjaviniar added a commit that referenced this issue Mar 20, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
604622f
bgambocjaviniar added a commit that referenced this issue Mar 20, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
e7f8f11
bgambocjaviniar added a commit that referenced this issue Mar 20, 2019
@bgambocjaviniar
Merge branch 'develop' into feature/GH-1321
bf8d784
@bgambocjaviniar bgambocjaviniar mentioned this issue Mar 22, 2019
Closed
KateChuen pushed a commit that referenced this issue Mar 22, 2019
@bgambocjaviniar @KateChuen
feat(@spartacus/storefront): Adding different viewports to e2e testing (
586f8ab 
GH-1321) (#1615)

* fix bugs and added new viewports

* fixed conflict

* fixed filter problem

* removed another timeout in e2e

* forgot to uncomment a line when I was testing locally

* improvements

* added changes with Kate

* added other mobile versions for safety

* added fix to big happy path

* added changes to places where classes changed

* finalized again, and I am 99% it is done

* test push to run the build again

* reverted the test to make it run again:

* chnaged mobile name too

* changed the old data set in e2e assertion to the new on in the server

* changed hardcoded url pointing to electronics to spa requests

* added fix for shipping tabs / test passes in dev-17-source-of-truth

* fixed unit test

* removed fdescribe in the unit test...
@plabadie plabadie mentioned this issue Mar 25, 2019
Closed
@Xymmer Xymmer modified the milestones: BETA-0, 1903-27 (0.1.0-alpha) Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e2e-tests
Projects
None yet
Milestone
1903-27 (0.1.0-alpha)
Development

No branches or pull requests
3 participants
@Xymmer @bgambocjaviniar @KateChuen