feat(@spartacus/storefront): Adding different viewports to e2e testing (GH-1321)

[bgambocjaviniar]

Closes #1321

Some mobile viewports for an e2e test does not exist at it was not necessary since it does not interact with mobile features, such as the hamburger, product search, and filter.

[marlass]

Tests should be placed only in smoke/regression directories, not in integration directory directly. It was changed a few days ago.

[marlass]

Avoid using should('exist') assertion. cy.get would fail if an element does not exist. No need to double check that. Look also at my other comment about files location.

[bgambocjaviniar]

Avoid using should('exist') assertion. cy.get would fail if an element does not exist. No need to double check that. Look also at my other comment about files location.

I agree with the file location. Very sorry! I forgot to move it, I was supposed to ask where I should put them yesterday, but for the assertion I kind of disagree.
https://docs.cypress.io/guides/core-concepts/introduction-to-cypress.html#Default-Assertions

Here it says we don't need to write .should('exist') as cy.get already does that, and that if we do chain any .should() command, it would no longer do the default assertion. I find that its better to explicitly say it other than implicitly because its more verbose and readable. For example, when a new developer starts working on cypress looks at cy.get('xx'), they probably would not know what it does unless they read the documentation, however, when they do cy.get('xx').should('exist'), they would understand it as it needs to exists in the dom

If you chain any .should() command, the default .should('exist') is not asserted.
^ From the link above

What do you think?

[KateChuen]

Move all mobile tests to a subfolder 'mobile' under regression.

[bgambocjaviniar]

Storefinder was not added for e2e tests because there will be a refactor on it #1510, #1372, #1469 , #1470

discussed with the team in Montreal