Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@spartacus/storefront): Adding different viewports to e2e testing (GH-1321) #1615

Merged
merged 34 commits into from
Mar 22, 2019
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
1960a16
fix bugs and added new viewports
bgambocjaviniar Mar 11, 2019
b99d54c
took changes from develop to my branch
bgambocjaviniar Mar 11, 2019
4c84750
fixed conflict
bgambocjaviniar Mar 11, 2019
677ef68
fixed filter problem
bgambocjaviniar Mar 11, 2019
cdb7940
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 11, 2019
a329ed5
removed another timeout in e2e
bgambocjaviniar Mar 11, 2019
d7d27dd
forgot to uncomment a line when I was testing locally
bgambocjaviniar Mar 12, 2019
205ca2f
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 12, 2019
f061ab6
improvements
bgambocjaviniar Mar 14, 2019
2fd2979
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 14, 2019
5aa643a
added changes with Kate
bgambocjaviniar Mar 18, 2019
9f47444
Merge branch 'develop' into feature/GH-1321
KateChuen Mar 18, 2019
d351eaa
added other mobile versions for safety
bgambocjaviniar Mar 18, 2019
18a7e70
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 18, 2019
56bf6da
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 19, 2019
d59728c
Merge branch 'develop' into feature/GH-1321
KateChuen Mar 19, 2019
eb90586
added fix to big happy path
bgambocjaviniar Mar 19, 2019
c6b1b09
added changes to places where classes changed
bgambocjaviniar Mar 19, 2019
e723844
Merge branch 'develop' into feature/GH-1321
KateChuen Mar 20, 2019
604622f
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 20, 2019
e7f8f11
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 20, 2019
b60e5d2
finalized again, and I am 99% it is done
bgambocjaviniar Mar 20, 2019
34a1ae4
test push to run the build again
bgambocjaviniar Mar 20, 2019
faafc8b
reverted the test to make it run again:
bgambocjaviniar Mar 20, 2019
bf8d784
Merge branch 'develop' into feature/GH-1321
bgambocjaviniar Mar 20, 2019
ea7749f
added conflicted files that were added today
bgambocjaviniar Mar 21, 2019
0dd13e2
fixed conflict from develop
bgambocjaviniar Mar 22, 2019
70c9397
chnaged mobile name too
bgambocjaviniar Mar 22, 2019
39ab46a
changed the old data set in e2e assertion to the new on in the server
bgambocjaviniar Mar 22, 2019
c646e5d
changed hardcoded url pointing to electronics to spa requests
bgambocjaviniar Mar 22, 2019
d5d0f2c
added fix for shipping tabs / test passes in dev-17-source-of-truth
bgambocjaviniar Mar 22, 2019
0ab4ecb
fixed conflicts
bgambocjaviniar Mar 22, 2019
411e4f1
fixed unit test
bgambocjaviniar Mar 22, 2019
4a8b874
removed fdescribe in the unit test...
bgambocjaviniar Mar 22, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into feature/GH-1321
KateChuen authored Mar 20, 2019

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
commit e723844f7eed6311b90e7d4a5153776b5c1846d4

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.