-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing functions addition #148
Conversation
There's a reason why some of these functions are not implemented. They are either for internal use (when it's the case, they are clearly documented as such) or not needed in C because of the API differences. Of course, some functions may also simply be missing, most likely those that were added recently 😉 |
Yup I know and I didn't implemented those, did I ? |
|
Ok, but should we add it anyway for the other SFML bindings (which are based on CSFML) ?
The doc just says :
So it may be used. |
Nop. |
@LaurentGomila how about the VertexBuffer functions? Would they be accepted if they were isolated in their own PR? |
Is |
It's surely there in SFML 2.5 :D |
Then OK, it should be in CSFML and SFML.Net too. |
@silverweed There's no need to split/reopen. All the functions in this PR are for the 2.5. @LaurentGomila Which name do you prefer |
I'd say |
@LaurentGomila Done. Maybe you can merge this now 😉 |
@LaurentGomila any news on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really sorry for the long wait on this 😓
Can you squash the two vertex buffer commits and fix the small style changes?
We can now call sfShader_createFromFile/Memory/Stream with only a geometry file/memory/stream.
…lements `sfRender[Window/Texture]_drawVertexBufferWithIndex`
Allowed myself to integrate the last commit in the relevant commits and rebase, as the pipeline was slightly outdated 😅 |
Thanks a lot for these fixes and the patience. 🥳 Sorry again it took so long 😞 |
I added some functions that were not implemented in CSFML.
I also modified sfTexture_bind, with an sfTextureCoordinateType arg.
Modified:
sfTexture_bind (Added sfTextureCoordinateType arg)
Added:
sfTextureCoordinateType
sfContext_isExtensionAvailable
sfContext_getFunction
sfRenderWindow_drawVertexBufferRange
sfRenderTexture_drawVertexBufferRange
sfTcpListener_close