Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] 3.1.6.1 Mirror Configuration - tiller image missing #633

Closed
Martin-Weiss opened this issue Dec 11, 2019 · 15 comments · Fixed by #957
Closed

[doc] 3.1.6.1 Mirror Configuration - tiller image missing #633

Martin-Weiss opened this issue Dec 11, 2019 · 15 comments · Fixed by #957
Labels
Bug A bug in the documentation that needs to be fixed DeploymentGuide Fix will change the Deployment Guide EngineeringInput NeedsEngineering Input
Milestone

Comments

@Martin-Weiss
Copy link
Contributor

3.1.6.1 Mirror Configuration

https://susedoc.github.io/doc-caasp/master/caasp-deployment/single-html/#airgap-container_registry-mirror


In https://documentation.suse.com/external-tree/en-us/suse-caasp/4/skuba-cluster-images.txt it seems we are missing the helm-tiller image...

@r0ckarong
Copy link
Contributor

@jordimassaguerpla Why would this image be missing?

@r0ckarong r0ckarong added Bug A bug in the documentation that needs to be fixed DeploymentGuide Fix will change the Deployment Guide Reported labels Dec 11, 2019
@Martin-Weiss
Copy link
Contributor Author

In case you try to do a helm init ..--tiller-image.. in an air-gapped environment. This will fail in case the image was not replicated to the on-premise registry beforehand...

@r0ckarong
Copy link
Contributor

In case you try to do a helm init ..--tiller-image.. in an air-gapped environment. This will fail in case the image was not replicated to the on-premise registry beforehand...

I understand but the question is why this is not listed in the images list, since it should.

@Martin-Weiss
Copy link
Contributor Author

In case you try to do a helm init ..--tiller-image.. in an air-gapped environment. This will fail in case the image was not replicated to the on-premise registry beforehand...

I understand but the question is why this is not listed in the images list, since it should.

Ok - just guessing - probably because this is "helm" related and does not matter for "skuba images...".

@r0ckarong
Copy link
Contributor

Maybe I misunderstand but the problem here is that the "chart" is there but can't find the "image" and that's because the image wasn't on the list you need to mirror.

@Martin-Weiss
Copy link
Contributor Author

Maybe I misunderstand but the problem here is that the "chart" is there but can't find the "image" and that's because the image wasn't on the list you need to mirror.

Yes - and the list of images that need to be mirrored are in https://documentation.suse.com/external-tree/en-us/suse-caasp/4/skuba-cluster-images.txt but probably we might need an other helm-images.txt which also covers the list of images we need for all the helm chart related images..

@r0ckarong
Copy link
Contributor

Maybe I misunderstand but the problem here is that the "chart" is there but can't find the "image" and that's because the image wasn't on the list you need to mirror.

Yes - and the list of images that need to be mirrored are in https://documentation.suse.com/external-tree/en-us/suse-caasp/4/skuba-cluster-images.txt but probably we might need an other helm-images.txt which also covers the list of images we need for all the helm chart related images..

Then I had a misunderstanding. I thought this list would also contain these. @jordimassaguerpla

@jordimassaguerpla
Copy link
Member

Don't we have already an issue for the helm ones?

@jordimassaguerpla
Copy link
Member

#621 Isn't this a duplicate?

@r0ckarong
Copy link
Contributor

#621 Isn't this a duplicate?

Not a duplicate because that one was about versioning in the file. We could use this one to track the other problem proven here and mentioned in the older one.

Is there any work underway to generate a list like that?

@Martin-Weiss
Copy link
Contributor Author

Basically we need a list of images for skuba images (that is what we have already).
Then we need a list of images for the helm charts we have to deploy with the version dependencies on skuba/k8s.
And we need a place for images that are neither skuba nor helm-charts related - at the moment this is just the helm-tiller image AFAIK and this is why I created this issue #633, here.

@r0ckarong
Copy link
Contributor

@jordimassaguerpla Any updates on this?

@jordimassaguerpla
Copy link
Member

A proposal is being discussed here https://github.com/SUSE/avant-garde/issues/1197

@r0ckarong r0ckarong added the Blocked Blocked by lack of information or external factors label Jan 14, 2020
@jordimassaguerpla jordimassaguerpla added this to the Sprint 21 milestone Jan 14, 2020
@r0ckarong r0ckarong removed the Blocked Blocked by lack of information or external factors label Jan 21, 2020
@r0ckarong r0ckarong added the Blocked Blocked by lack of information or external factors label Jan 27, 2020
@r0ckarong r0ckarong modified the milestones: Sprint 22, Sprint 23 Feb 24, 2020
@r0ckarong r0ckarong added the EngineeringInput NeedsEngineering Input label May 14, 2020
@jodavis-suse
Copy link
Contributor

It does seem like we should add some explanation to https://susedoc.github.io/doc-caasp/master/single-html/caasp-deployment/#airgap-container_registry-mirror to call out the Tiller image. While tiller is in registry.suse.com, it isn't called out in the https://documentation.suse.com/external-tree/en-us/suse-caasp/4/skuba-cluster-images.txt as it is not used by skuba. We don't need to create a helm-images.txt file to match that, because helm-mirror will generate the list of images for us and again, that list isn't going to include Tiller because Tiller isn't installed by a chart but from a helm command line call which passes the image name.

(It is really tempting to say 'just use Helm 3 in airgapped environments and skip Tiller', but as we don't have that packaged for CaaSP 4 that isn't helpful.)

jodavis-suse added a commit to jodavis-suse/doc-caasp that referenced this issue Aug 3, 2020
Also fix the skopeo command line options to match command line options
that are actually available with the  0.1.41 package. (SUSE#954)
@jodavis-suse
Copy link
Contributor

I attempted to walk all the steps in a local setup, though had some trouble with the docker mirror setup (likely due to some of my shortcuts to avoid having to actually use two different SLES systems). Result is in PR #957

@r0ckarong r0ckarong linked a pull request Aug 4, 2020 that will close this issue
r0ckarong pushed a commit that referenced this issue Aug 5, 2020
* Add detail for Helm and Tiller installation (#633)

Also fix the skopeo command line options to match command line options
that are actually available with the  0.1.41 package. (#954)

* Update the tiller version to reflect caasp/v4.5 and 2.16.9

Co-authored-by: Markus Napp <mnapp@suse.com>
r0ckarong pushed a commit that referenced this issue Aug 5, 2020
* Add detail for Helm and Tiller installation (#633)

Also fix the skopeo command line options to match command line options
that are actually available with the  0.1.41 package. (#954)

* Update the tiller version to reflect caasp/v4.5 and 2.16.9

Co-authored-by: Markus Napp <mnapp@suse.com>
@dannysauer dannysauer removed the Blocked Blocked by lack of information or external factors label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the documentation that needs to be fixed DeploymentGuide Fix will change the Deployment Guide EngineeringInput NeedsEngineering Input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants