Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail for Helm and Tiller installation (#633) #957

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

jodavis-suse
Copy link
Contributor

Also fix the skopeo command line options to match command line options
that are actually available with the 0.1.41 package. (#954)

Describe your changes

The existing air-gapped instructions did not have any detail about how to install Tiller. Tiller is required for Helm 2 and the 'helm init' command by default tries to fetch the helm-tiller image from the internet. Additional steps were added to mirror the helm-tiller image, as helm-tiller is included neither with the list of images needed by skuba nor with the list of images generated from the chart list.

Additionally, I found that the skopeo command line options had changed and needed to be adjusted to work.

After this is merged to master, it should be backported to any 4.2 documentation for completeness.

Related Issues / Projects

Relates to:
#633
#954

v4.5
v4.2

Also fix the skopeo command line options to match command line options
that are actually available with the  0.1.41 package. (SUSE#954)
Copy link
Contributor

@suseclee suseclee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r0ckarong r0ckarong linked an issue Aug 4, 2020 that may be closed by this pull request
@r0ckarong r0ckarong added this to the Sprint 36 milestone Aug 4, 2020
@r0ckarong r0ckarong self-assigned this Aug 4, 2020
@r0ckarong r0ckarong added 4.2.2 4.5.0 CaasP v5 release without Rancher DeploymentGuide Fix will change the Deployment Guide labels Aug 4, 2020
@jodavis-suse
Copy link
Contributor Author

jodavis-suse commented Aug 4, 2020

Sorry @suseclee I realized I didn't document the v4.5 path for the tiller image, so did a quick update to the commit.

If we do backport this, the CaaSP 4.2 document version should use the "v4" path and "2.16.1" version, as was originally posted.

@r0ckarong r0ckarong modified the milestones: Sprint 36, Sprint 35 Aug 5, 2020
@r0ckarong r0ckarong merged commit a1b30f7 into SUSE:master Aug 5, 2020
r0ckarong pushed a commit that referenced this pull request Aug 5, 2020
* Add detail for Helm and Tiller installation (#633)

Also fix the skopeo command line options to match command line options
that are actually available with the  0.1.41 package. (#954)

* Update the tiller version to reflect caasp/v4.5 and 2.16.9

Co-authored-by: Markus Napp <mnapp@suse.com>
@r0ckarong r0ckarong linked an issue Aug 7, 2020 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.2.2 4.5.0 CaasP v5 release without Rancher DeploymentGuide Fix will change the Deployment Guide
Projects
None yet
3 participants