Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] 3.3.2 Deploying the Infrastructure #772

Closed
zoopster opened this issue Apr 20, 2020 · 12 comments · Fixed by #782
Closed

[doc] 3.3.2 Deploying the Infrastructure #772

zoopster opened this issue Apr 20, 2020 · 12 comments · Fixed by #782
Labels
Bug A bug in the documentation that needs to be fixed DeploymentGuide Fix will change the Deployment Guide ReleaseNotes Fix has impact that needs to be mentioned in the release notes v4 CaaSP v4

Comments

@zoopster
Copy link

In this section if you leave the iam_profile_master and iam_profile_worker empty, TF does not create the proper IAM Profile even with explicit IAM_Passthru rights or the use of root credentials.
The deployment will fail with a "cannot attach profile" error.
If you add/uncomment these lines, the deployment will finish however the skuba node bootstrap will fail with a error listing instances error.

3.3.2 Deploying the Infrastructure

https://documentation.suse.com/suse-caasp/4.1/single-html/caasp-deployment/#_deploying_the_infrastructure

@r0ckarong r0ckarong added Bug A bug in the documentation that needs to be fixed DeploymentGuide Fix will change the Deployment Guide v4 CaaSP v4 labels Apr 20, 2020
@r0ckarong
Copy link
Contributor

@flavio @ereslibre What is going wrong here? What is the correct procedure to do this?

@innobead
Copy link
Contributor

cc @cclhsu @maximenoel8

@cclhsu
Copy link
Contributor

cclhsu commented Apr 27, 2020

fix issue for aws iam profile [bsc#1169506] (1517) #1058 shoudl fixes this issue.

@r0ckarong r0ckarong added the ReleaseNotes Fix has impact that needs to be mentioned in the release notes label Apr 27, 2020
@r0ckarong
Copy link
Contributor

r0ckarong commented Apr 27, 2020

@cclhsu Does this need any additional docs updates?

@cclhsu
Copy link
Contributor

cclhsu commented Apr 27, 2020

@r0ckarong No document update required, we only need to update terraform file to properly create iam and instance profile.

@r0ckarong
Copy link
Contributor

@jordimassaguerpla We should add this to the known issues until it's merged.

@jordimassaguerpla
Copy link
Member

@r0ckarong Does it need to have some content or just the bug mentioned?

@r0ckarong
Copy link
Contributor

r0ckarong commented Apr 27, 2020

@jordimassaguerpla To do it right, we would have to explain the entire workaround with doing the steps terraform is missing by hand but I'm not sure if you can salvage an already failed deployment that way.
If we just mention the issue then AWS is basically non functional until we ship the patch.

Not sure what to do with the right amount of effort.

@kkaempf What do you think?

@kkaempf
Copy link
Member

kkaempf commented Apr 27, 2020

That's one of the problems with "tech previews". :-/

If we just mention the issue then AWS is basically non functional until we ship the patch.

Well, if it's really non functional, that's embarrassing 🤦

Workaround for now:

  • document it in the release notes
  • make a fixed package available internally (+ announce it on caasp-internal)
  • wait for bug reports

Not perfect, but (imho) a minimal effort approach.

@zoopster
Copy link
Author

If you simply document the workaround (setup the instance profile prior) then the fix to the tf files can come later and it's functional until then.

@r0ckarong
Copy link
Contributor

r0ckarong commented Apr 27, 2020

@cclhsu Could you provide the steps required to set up the IAM profile to work around this? I think linking to this specification (https://github.com/kubernetes/cloud-provider-aws#readme) and some steps on how to achieve this on AWS would suffice? Can any user just use the profile examples from the bugzilla thread?

@zoopster
Copy link
Author

Through the aws console...it's just a matter of creating a role with the documented policy (in iam_policies.tf) and the instance profile will be created automatically with the same name of the role. That role/instance profile name needs to be added to the terraform.tfvars (where the commented caasp-k8s-master-vm-profile is noted). If you need specific docs...happy to create them...

cclhsu pushed a commit to cclhsu/doc-caasp that referenced this issue Apr 28, 2020
add documents for create role instance policy and profile (SUSE#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>
cclhsu pushed a commit to cclhsu/doc-caasp that referenced this issue Apr 28, 2020
add documents for create role instance policy and profile (SUSE#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>
cclhsu pushed a commit to cclhsu/doc-caasp that referenced this issue Apr 28, 2020
add documents for create role instance policy and profile (SUSE#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>
cclhsu pushed a commit to cclhsu/doc-caasp that referenced this issue Apr 28, 2020
add documents for create role instance policy and profile (SUSE#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>
cclhsu pushed a commit to cclhsu/doc-caasp that referenced this issue Apr 30, 2020
fix suggestions from document review for create role instance policy and profile (SUSE#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>
r0ckarong pushed a commit that referenced this issue Apr 30, 2020
…file (Closes #772)

* add documents for create role instance policy and profile (#772)

add documents for create role instance policy and profile (#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>

* add documents for create role instance policy and profile (#772)

add documents for create role instance policy and profile (#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>

* Added anchors to AWS IAM profile sections

* fix suggestions for create role instance policy and profile (#772)

fix suggestions from document review for create role instance policy and profile (#772)

Signed-off-by: cclhsu <clark.hsu@suse.com>

* Update adoc/deployment-aws.adoc

Co-Authored-By: David Ko <dko@suse.com>

* Move AWS IAM profile creation via CLI to troubleshooting

* Move AWS IAM profile creation via CLI to troubleshooting

* Remove obsolete message about IAM profile

Co-authored-by: Markus Napp <mnapp@suse.com>
Co-authored-by: David Ko <dko@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the documentation that needs to be fixed DeploymentGuide Fix will change the Deployment Guide ReleaseNotes Fix has impact that needs to be mentioned in the release notes v4 CaaSP v4
Projects
None yet
6 participants