fix issue for aws iam profile [bsc#1169506] (1517)

[cclhsu]

Fix issue items for aws iam profile [bsc#1169506]

Signed-off-by: cclhsu clark.hsu@suse.com

Why is this PR needed?

Fix issue items for aws iam profile [bsc#1169506]

Fixes #1517

What does this PR do?

Create aws_iam_role and aws_iam_policy

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Info for QA

This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.

Related info

Info that can be relevant for QA:

• link to other PRs that should be merged together
• link to packages that should be released together
• upstream issues

Status BEFORE applying the patch

How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.

In terraform.tfvar, comment out following:

# iam_profile_master = "caasp-k8s-master-vm-profile"
# iam_profile_worker = "caasp-k8s-worker-vm-profile"

Deploy AWS in non-openbare account will not success.

Status AFTER applying the patch

How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.

Deploy AWS in non-openbare account will be successful.

Docs

If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

[innobead]

LGTM. Some suggestions to resolve.

[c3y1huang]

Is there a test case for this fix?

[innobead]

Is there a test case for this fix?

Good ask ;) @cclhsu please add a test case in caasp-test-cases. cc @maximenoel8

[jenting]

I don't have an account with permission to create an IAM role to do the test, so personally, I'd prefer let QA testing this PR and approve it.

[flavio]

I cannot test it because I do not have a non-openbare account. But it looks good to me

[zoopster]

These changes worked for me as written.

[cclhsu]

Have tested after merged. Deployed successfully

[maximenoel8]

Have tested the deployment with and without iam_profile. It's working fine for me